Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#209870 broke llvmPackages_13.compiler-rt-libc #225779

Closed
ghost opened this issue Apr 11, 2023 · 7 comments
Closed

#209870 broke llvmPackages_13.compiler-rt-libc #225779

ghost opened this issue Apr 11, 2023 · 7 comments
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related

Comments

@ghost
Copy link

ghost commented Apr 11, 2023 •
edited by ghost
Loading

Another regression: llvmPackages_13.compiler-rt-libc. #225220 does not fix it.

Originally posted by @alyssais in #209870 (comment)
@ghost
Copy link
Author

ghost commented Apr 11, 2023

@vcunat wrote

I just succeeded with llvmPackages_rocm.clang this way, as an experiment in vcunat@14fd6d2aaaec82.

@ghost ghost self-assigned this Apr 11, 2023
@ghost ghost mentioned this issue Apr 11, 2023
Merged
4 tasks
@ghost ghost changed the title #209870 broke llvmPackages_13.compiler-rt-libc. https://github.com/NixOS/nixpkgs/pull/225220 does not fix it. #209870 broke llvmPackages_13.compiler-rt-libc Apr 11, 2023
@ghost

This comment was marked as outdated.

Sign in to view
@ghost

This comment was marked as off-topic.

Sign in to view
@ghost
Copy link
Author

ghost commented Apr 12, 2023

NIX_CFLAGS_COMPILE+="v"-then-nuke-refs-then-diff gives:

screenshot-20230411-233347

@ghost
Copy link
Author

ghost commented Apr 12, 2023 •
edited by ghost
Loading

screenshot-20230412-001109

https://github.com/gcc-mirror/gcc/blob/5582ad0afb051a76231b2959487f4ef1746df283/gcc/gcc.cc#L549-L551

Which is implemented as:

screenshot-20230412-001116

https://github.com/gcc-mirror/gcc/blob/5582ad0afb051a76231b2959487f4ef1746df283/gcc/gcc.cc#L6423-L6435

Which comes from:

screenshot-20230412-001121

https://github.com/gcc-mirror/gcc/blob/5582ad0afb051a76231b2959487f4ef1746df283/gcc/gcc.cc#L4505-L4506

So the root problem is the first red-text block in the image above. Once that -B is in there, gcc will automatically add the offending -isystem flags due to the specs file.

So it's just that one extra -B that's causing all the trouble.

@ghost ghost mentioned this issue Apr 12, 2023
Merged
@ghost
Copy link
Author

ghost commented Apr 12, 2023

Verifying possible fix (#225846)...

@ghost
Copy link
Author

ghost commented Apr 12, 2023

Fixed by #225846

@ghost ghost closed this as completed Apr 12, 2023
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrbutani