Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pantheon: screenshots are darker when selecting the area #100434

Closed
davidak opened this issue Oct 13, 2020 · 9 comments · Fixed by #130380
Closed

Pantheon: screenshots are darker when selecting the area #100434

davidak opened this issue Oct 13, 2020 · 9 comments · Fixed by #130380
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: pantheon The Pantheon desktop environment

Comments

@davidak
Copy link
Member

davidak commented Oct 13, 2020

Describe the bug
When i create a screenshot using PRINT key, it's as expected.

Screenshot from 2020-10-13 20-05-36

But when i select an area, it is darker.

Screenshot from 2020-10-13 20-02-05

Not when i select a window.

Screenshot from 2020-10-13 20-08-27

To Reproduce
Steps to reproduce the behavior:

  1. use pantheon desktop
  2. snapshot using SHIFT + PRINT
  3. see snapshot

Expected behavior
image not altered

Additional context
was not an issue in 20.03

Notify maintainers
@worldofpeace

Metadata

  • system: "x86_64-linux"
  • host os: Linux 5.8.13, NixOS, 20.09beta992.7badbf18c45 (Nightingale)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.7
  • channels(root): "home-manager-20.09, nixos-20.09beta992.7badbf18c45, nixos-hardware, nixos-unstable-21.03pre246062.420f89ceb26"
  • nixpkgs: /home/davidak/.cache/nixpkgs-review/pr-99931/nixpkgs

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
@davidak davidak added 0.kind: bug 6.topic: pantheon The Pantheon desktop environment labels Oct 13, 2020
@davidak
Copy link
Member Author

davidak commented Oct 14, 2020

This seems to be fixed after an update.

  • system: "x86_64-linux"
  • host os: Linux 5.8.14, NixOS, 20.09beta1057.0b8799ecaaf (Nightingale)
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.3.7
  • channels(root): "home-manager-20.09, nixos-20.09beta1057.0b8799ecaaf, nixos-hardware, nixos-unstable-21.03pre246062.420f89ceb26"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

@davidak davidak closed this as completed Oct 14, 2020
@davidak
Copy link
Member Author

davidak commented Oct 14, 2020

Oh noooooooooooooooooooooooooooooooo it's there again.

@davidak davidak reopened this Oct 14, 2020
@davidak
Copy link
Member Author

davidak commented Oct 21, 2020

I guess the dark space is the selection that is not removed quickly enough, so it is a timing issue. You can even see the border in the screenshot!

Screenshot from 2020-10-21 13-33-11

@worldofpeace can you reproduce it? don't happen always, but in 3 of 5 cases...

this is a blocker for me since my work involves taking screenshots a lot. i don't want it to block the release, but it has higher priority than the other issues i reported

still happens in latest 20.09beta1322.ba2ec4867d7

@worldofpeace
Copy link
Contributor

I've never had this issue. This has to do with the screenshot window timeouts, see these issues elementary/screenshot#50 elementary/gala#211. In the issue for gala someone was actually able to reproduce it recently elementary/gala#211 (comment).
The issue here is, pantheon's development is steered to their upcoming release. So gala master and screenshot master are way ahead. So we'd have to try to reproduce on those, but currently gala master doesn't build elementary/gala#915. I intend to fix that issue but I have too much to do sometimes.

@worldofpeace
Copy link
Contributor

Opened a PR to fix that in gala elementary/gala#945

@davidak
Copy link
Member Author

davidak commented Oct 28, 2020

Great. The PR was merged. Do you plan to backport it?

@worldofpeace
Copy link
Contributor

Great. The PR was merged. Do you plan to backport it?

I'd doesn't fix this exact issue. Currently those other reports I linked prove that the current state is a regression, or on your machine the timeout isn't sufficent

@davidak
Copy link
Member Author

davidak commented Oct 29, 2020

Just checked. This issue is not present in NixOS 20.03.3185.6b5f85a62c4.

@stale
Copy link

stale bot commented Jun 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2021
@davidak davidak mentioned this issue Jul 22, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: pantheon The Pantheon desktop environment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants