Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin used dependencies with PipLock #33

Open
szszszsz opened this issue Jul 28, 2020 · 5 comments
Open

Pin used dependencies with PipLock #33

szszszsz opened this issue Jul 28, 2020 · 5 comments

Comments

@szszszsz
Copy link
Member

To introduce automatic pinning, e.g. with Pipenv tool.
@daringer : what do you think?

@daringer
Copy link
Collaborator

daringer commented Jul 28, 2020

Yap, sounds good
already using a hackish solution via dev-requirements.txt

@dvzrv
Copy link

dvzrv commented Aug 15, 2020

As you are already using pyproject.toml, why not use poetry instead of pipenv?

@szszszsz
Copy link
Member Author

Hi @dvzrv !

Thank you for the suggestion! Last time I have checked poetry had own issues, hence I wanted to stay with the one I know until the other matures. Worth looking again on poetry definitely.

@szszszsz
Copy link
Member Author

szszszsz commented Aug 19, 2020

@dvzrv By the way, why do you advocate for poetry?
Is it only because of the pyproject.toml file, or do you have some other things in mind?

@dvzrv
Copy link

dvzrv commented Aug 19, 2020

@dvzrv By the way, why do you advocate for poetry?
Is it only because of the pyproject.toml file, or do you have some other things in mind?

It's mainly because it (currently) seems to be one of the few "all-in-one" solutions (pipenv had so many awkward flaws - e.g. pypa/pipenv#2364 - and yes, to my knowledge does not support pyproject.toml). It's fairly convenient, because it can:

  • pin your dependencies
  • manage your venvs
  • allow easy interaction with venvs
  • allow for creation of source tarballs or wheels
  • allow for tests with tox on several python interpreter versions (but it does not auto-handle e.g. pyenv for you - which IMHO is good)
  • publish to pypi

On the downside: Its use of venvs is not necessarily super fast, but then again, venvs are generally not super fast (it's the same for pipenv). ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants