Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xDrip updater only works for the Nightly channel #2146

Closed
Lupum1001 opened this issue May 26, 2022 · 11 comments
Closed

xDrip updater only works for the Nightly channel #2146

Lupum1001 opened this issue May 26, 2022 · 11 comments
Labels
bug any kind of software error

Comments

@Lupum1001
Copy link
Contributor

I'm currently running the build from Oct 4, 2021 and I can't get xDrip to detect any new releases from the Stable/Beta/Alpha channels.
In theory, it should detect the build from Jan 31st, but it currently only can detect builds from the nightly channel.

Link to discussion thread: #2145


My Environment:

Samsung Galaxy S21 phone running xDrip version:
49817a5-2021.10.04
Code: 2110041402

Expected behavior

When I check for an update, either by switching channels (which triggers a check), or pressing the explicit "check for updated version" menu item, I'd expect to see the usual pop-up offering an update to the Jan 31st build.

Actual behavior

When I've selected the Stable, Beta, or Alpha channels, I don't get a pop-up. This is also true if I explicitly press the "check for updated version" button in the Home screen dropdown menu.
It will detect the nightly builds, if I select that channel, but that's it.

@Navid200 Navid200 added the bug any kind of software error label May 26, 2022
@Navid200
Copy link
Collaborator

I would change the title to "xDrip updater only works for the Nightly channel".
But, that's just a suggestion. Keep it if you like.

@Lupum1001 Lupum1001 changed the title xDrip Updater not detecting new releases xDrip updater only works for the Nightly channel May 26, 2022
@Navid200
Copy link
Collaborator

@jamorham
1- I remember people getting updates from the beta channel from posts in facebook in 2021.
2- I installed versions all the way back to September 2020 and they all have this problem.

Putting 1 and 2 together, the problem cannot be in the code. It must be with the links. But, I don't understand what. I'm not sure what to look for.

@Lupum1001
Copy link
Contributor Author

Looking at the code, My first instinct is an integer overflow.

In ascending order:
2110041402 - My installed version
2122051908 - latest from nightly channel (not sure why this doesn't start with a 22, tbh)
2147483647 - maximum value of signed 32-bit integer
2201310800 - latest from Stable/Beta/Alpha channels

image

@Lupum1001
Copy link
Contributor Author

Lupum1001 commented May 26, 2022

Looks like @jamorham patched the version numbers issue on January 3rd: 666f578

It seems to be working for the nightly build urls, and the actual contents of the January release are fine (if you install the apk, it correctly self-identifies as 2122013118); it's just labeled wrong, so xdrip rejects it.

I'm not sure why xdrip-plus-updates.appspot.com and the actual apk would disagree on the version number. I assume there's just a patch on the website that was applied to the nightly channel, but not the others.

@jamorham
Copy link
Collaborator

Thanks for noticing this. Please can anyone who is interested check if the alpha channel is now working correctly? Thanks.

@Lupum1001
Copy link
Contributor Author

👍 Yes, Alpha is now working for me. It shows version 2122051908 (May 19th build)

@Navid200
Copy link
Collaborator

Yes, alpha is working pointing to a very very recent Nightly, the current one.

@jamorham
Copy link
Collaborator

I've promoted the currently nightly to alpha which is why it shows as the May 19th one.

@Lupum1001
Copy link
Contributor Author

Lupum1001 commented May 29, 2022

https://xdrip-plus-updates.appspot.com/update-check/stable

2201310800
https://github.com/NightscoutFoundation/xDrip/releases/download/2022.01.31/xDrip-plus-20220131-33be05a.apk?
12779931

c28cc7f8786c7147876caf0cd869af33e0a8e09a4f4bfc8ffe7e2c1456bd36db

https://xdrip-plus-updates.appspot.com/update-check/nightly

2122051908
https://github.com/NightscoutFoundation/xDrip/releases/download/2022.05.19/xDrip-plus-20220519-e557cba.apk?
13050888

44b24ed125a1425b9497af9136e31355e1ec9ec8dc477110ec8c2572685bce19

Is it possible to update the version # of the January release on appspot?
As I mentioned earlier, the file already thinks it's 2122013118, so it's just appspot's metadata for that file causing issues.

(P.S. feel free to close this issue if you feel it's resolved)

@Navid200
Copy link
Collaborator

Navid200 commented Jun 12, 2022

On Monday, June 13 2022, the Beta and Stable channels will change from January 31, 2022, to May 19, 2022.

If you are on the Beta or Stable channels, you may get a notification that a new update is available for you.
You can go ahead and download and update.

Do you have to update?
You never have to update. But, you can.

You can read about how update channels work here: https://navid200.github.io/xDrip/docs/Updates.html

@Navid200
Copy link
Collaborator

All update channels are working fine now.

We can reopen if you are still experiencing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug any kind of software error
Projects
None yet
Development

No branches or pull requests

3 participants