-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xDrip updater only works for the Nightly channel #2146
Comments
I would change the title to "xDrip updater only works for the Nightly channel". |
@jamorham Putting 1 and 2 together, the problem cannot be in the code. It must be with the links. But, I don't understand what. I'm not sure what to look for. |
Looking at the code, My first instinct is an integer overflow. In ascending order: |
Looks like @jamorham patched the version numbers issue on January 3rd: 666f578 It seems to be working for the nightly build urls, and the actual contents of the January release are fine (if you install the apk, it correctly self-identifies as 2122013118); it's just labeled wrong, so xdrip rejects it. I'm not sure why xdrip-plus-updates.appspot.com and the actual apk would disagree on the version number. I assume there's just a patch on the website that was applied to the nightly channel, but not the others. |
Thanks for noticing this. Please can anyone who is interested check if the alpha channel is now working correctly? Thanks. |
👍 Yes, Alpha is now working for me. It shows version 2122051908 (May 19th build) |
Yes, alpha is working pointing to a very very recent Nightly, the current one. |
I've promoted the currently nightly to alpha which is why it shows as the May 19th one. |
Is it possible to update the version # of the January release on appspot? (P.S. feel free to close this issue if you feel it's resolved) |
On Monday, June 13 2022, the Beta and Stable channels will change from January 31, 2022, to May 19, 2022. If you are on the Beta or Stable channels, you may get a notification that a new update is available for you. Do you have to update? You can read about how update channels work here: https://navid200.github.io/xDrip/docs/Updates.html |
All update channels are working fine now. We can reopen if you are still experiencing the problem. |
I'm currently running the build from Oct 4, 2021 and I can't get xDrip to detect any new releases from the Stable/Beta/Alpha channels.
In theory, it should detect the build from Jan 31st, but it currently only can detect builds from the nightly channel.
Link to discussion thread: #2145
My Environment:
Samsung Galaxy S21 phone running xDrip version:
49817a5-2021.10.04
Code: 2110041402
Expected behavior
When I check for an update, either by switching channels (which triggers a check), or pressing the explicit "check for updated version" menu item, I'd expect to see the usual pop-up offering an update to the Jan 31st build.
Actual behavior
When I've selected the Stable, Beta, or Alpha channels, I don't get a pop-up. This is also true if I explicitly press the "check for updated version" button in the Home screen dropdown menu.
It will detect the nightly builds, if I select that channel, but that's it.
The text was updated successfully, but these errors were encountered: