Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sequence / segment attribute names 'onset_Hz' and 'offset_Hz' #87

Closed
NickleDave opened this issue May 22, 2021 · 0 comments
Closed
Assignees
Labels
ENH: enhancement New feature or request

Comments

@NickleDave
Copy link
Collaborator

NickleDave commented May 22, 2021

@yardencsGitHub points out 'Hz' is confusing since it is a frequency -- I used it because I wanted something quick to type (and I'm a bad physicist who abuses units of measure)

Maybe 'onset_sample_ind' and 'offset_sample_ind'? 'onset_index' and 'offset_index'?
This is one of those cases where there's no good short name.
'onset_ind' and 'offset_ind' might have to suffice and then for clarity it would need to be clearly defined in docstrings, examples, etc.

@NickleDave NickleDave self-assigned this May 22, 2021
@NickleDave NickleDave added the ENH: enhancement New feature or request label Dec 2, 2021
@NickleDave NickleDave added this to the 4.0 milestone Dec 2, 2021
@NickleDave NickleDave removed this from the 4.0 milestone Jan 2, 2022
NickleDave added a commit that referenced this issue Jan 2, 2022
CLN: rename `on/offsets_Hz` -> `on/offset_inds`, fix #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant