Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New hooks to do things after setting transaction manager to explicit mode #22

Closed
jamadden opened this issue Sep 5, 2019 · 0 comments · Fixed by #24
Closed

New hooks to do things after setting transaction manager to explicit mode #22

jamadden opened this issue Sep 5, 2019 · 0 comments · Fixed by #24

Comments

@jamadden
Copy link
Member

jamadden commented Sep 5, 2019

See comments on #20
jamadden added a commit that referenced this issue Sep 5, 2019
@jamadden
Add additional hooks for subclasses
0a04f5a 
Fixes #22

Also some minor refactoring with an eye towards speed and simplicity.
We get between 5 and 10% faster, even accounting for all the overhead
of raising exceptions:

+----------------+---------------+------------------------------+
| Benchmark      | masterresults | issue22results               |
+================+===============+==============================+
| trivial commit | 14.9 us       | 13.2 us: 1.12x faster (-11%) |
+----------------+---------------+------------------------------+
| max retries    | 16.0 us       | 15.1 us: 1.06x faster (-5%)  |
+----------------+---------------+------------------------------+
@jamadden jamadden mentioned this issue Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional hooks for subclasses OpenNTI/nti.transactions
1 participant
@jamadden