Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction loop should use explicit transaction manager mode #20

Closed
jamadden opened this issue Sep 5, 2019 · 1 comment
Closed

Transaction loop should use explicit transaction manager mode #20

jamadden opened this issue Sep 5, 2019 · 1 comment

Comments

@jamadden
Copy link
Member

jamadden commented Sep 5, 2019

This triggers better polling behaviour in a ZODB Connection (such as used with https://github.com/NextThought/nti.site/blob/master/src/nti/site/runner.py#L141)

@jamadden
Copy link
Member Author

jamadden commented Sep 5, 2019

Of course, if we do it in our __call__, the connection that was opened by our subclass in nti.site doesn't get to take full advantage of that (because it opens the connection before calling us). Sigh.

So we need some extra hooks here to make that possible and/or we need to modify nti.site (e.g., to move opening the connection down into run_handler instead of __call__ — but having the same connection be used in all retry attempts is probably the right behaviour as it'll have the best cache).

jamadden added a commit that referenced this issue Sep 5, 2019
And remove legacy freeing of transaction resources that hadn't been needed since transaction 1.6 or so. Fixes #18.
jamadden added a commit that referenced this issue Sep 5, 2019
Use an explicit transaction manager. Fixes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant