-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bus): implement HTTP command dispatcher #20
feat(bus): implement HTTP command dispatcher #20
Conversation
21ee286
to
403d18f
Compare
Code Climate has analyzed commit 376d435 and detected 6 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.2%. View more on Code Climate. |
49478ac
to
8cd75a7
Compare
362f2c4
to
a578261
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanReznichenko you should provide a complete and sufficient description of how to use HttpCommandDispatcher
, how to perform different kinds of requests, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomanReznichenko documentation is absolutely not accurate, you use wrong and unknown symbols. Moreover, there are a. huge amount of grammar and spelling mistakes. Please use grammarly.com to verify yourself next time.
closes #19