Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bus): implement HTTP command dispatcher #20

Merged

Conversation

RomanReznichenko
Copy link
Contributor

closes #19

@RomanReznichenko RomanReznichenko force-pushed the feat/http-command-dispatcher branch from 21ee286 to 403d18f Compare April 11, 2022 13:43
@codeclimate
Copy link

codeclimate bot commented Apr 11, 2022

Code Climate has analyzed commit 376d435 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 4

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.2%.

View more on Code Climate.

@derevnjuk derevnjuk force-pushed the feat/http-command-dispatcher branch from 49478ac to 8cd75a7 Compare April 12, 2022 18:23
@derevnjuk derevnjuk force-pushed the feat/http-command-dispatcher branch from 362f2c4 to a578261 Compare April 12, 2022 18:28
@derevnjuk derevnjuk changed the title feat(bus): implement http command dispatcher feat(bus): implement HTTP command dispatcher Apr 12, 2022
Copy link
Member

@derevnjuk derevnjuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanReznichenko you should provide a complete and sufficient description of how to use HttpCommandDispatcher, how to perform different kinds of requests, etc

@pmstss pmstss merged commit ec3b30d into NeuraLegion:master Apr 13, 2022
Copy link
Member

@derevnjuk derevnjuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanReznichenko documentation is absolutely not accurate, you use wrong and unknown symbols. Moreover, there are a. huge amount of grammar and spelling mistakes. Please use grammarly.com to verify yourself next time.

packages/bus/README.md Show resolved Hide resolved
packages/bus/README.md Show resolved Hide resolved
packages/bus/README.md Show resolved Hide resolved
packages/bus/README.md Show resolved Hide resolved
packages/bus/README.md Show resolved Hide resolved
packages/bus/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HTTP command dispatcher
3 participants