Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition members' precedence #96

Closed
derevnjuk opened this issue May 20, 2022 · 0 comments · Fixed by #97
Closed

Condition members' precedence #96

derevnjuk opened this issue May 20, 2022 · 0 comments · Fixed by #97
Assignees
@derevnjuk
Labels
Type: bug Something isn't working

Comments

@derevnjuk
Copy link
Member

If the scan finds an issue and enters into the done statue at the same time, the custom predicate won't be verified

 const preventFurtherPolling =
        (await predicate()) || this.done || timeoutPassed;

To get a chance to satisfy the predicate, we should change the condition members' precedence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derevnjuk derevnjuk

Labels
Type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scan): change the condition members' precedence NeuraLegion/sectester-js
1 participant
@derevnjuk