Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional argument Address in parity_pendingTransactions #4361

Closed
marcindsobczak opened this issue Aug 4, 2022 · 1 comment · Fixed by #4413
Closed

Add optional argument Address in parity_pendingTransactions #4361

marcindsobczak opened this issue Aug 4, 2022 · 1 comment · Fixed by #4413
Labels
good first issue

Comments

@marcindsobczak
Copy link
Contributor

In rpc method:
https://docs.nethermind.io/nethermind/ethereum-client/json-rpc/parity#parity_pendingtransactions

Will be nice to add optional argument Address to let users opportunity to ask about txs from specific address only.

If optional argument Address will not be null, there will be a need to filter txs by this address inside Where
https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.JsonRpc/Modules/Parity/ParityRpcModule.cs#L70-L73
@Mohiiit
Copy link

Mohiiit commented Aug 7, 2022

Hey, I would like to contribute. Can you provide me with some resources to get started?

@smartprogrammer93 smartprogrammer93 mentioned this issue Aug 11, 2022
Merged
12 tasks
@smartprogrammer93 smartprogrammer93 linked a pull request Aug 11, 2022 that will close this issue
Add optional argument Address in parity_pendingTransactions #4413
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optional argument Address in parity_pendingTransactions NethermindEth/nethermind
3 participants
@smartprogrammer93 @Mohiiit @marcindsobczak