Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PivotUpdator to be really infinite #5992

Open
marcindsobczak opened this issue Aug 9, 2023 · 3 comments
Open

Refactor PivotUpdator to be really infinite #5992

marcindsobczak opened this issue Aug 9, 2023 · 3 comments

Comments

@marcindsobczak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now we are using MaxAttemptsToUpdatePivot = int.MaxValue, which is enough, because it means that node is trying to update pivot for ~68 years before giving up. But making it really infinite would be nice.

Describe the solution you'd like
Refactor code to make infinite attempts to update pivot if MaxAttemptsToUpdatePivot is e.g. -1

Additional context
Automatic pivot updates were introduced here: #5256
And changed to "infinite" here: #5988

@rupak21
Copy link

rupak21 commented Sep 15, 2023

i want to fix this issue. but when i cloned it started it in docker it was giving me issues.
Screenshot 2023-09-14 165821

@kamilchodola
Copy link
Contributor

@marcindsobczak we can close, right?

@Mitish98
Copy link

I am applying to this issue via OnlyDust platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants