eth_getfilterchanges response error code on filter not found

[jeremyjams]

Description
If the filter is not found, the Nethermind eth_getfilterchanges JSON-RPC API response error code is expected to behave like other Ethereum clients.

Further examples illustrates response error codes of couple Ethereum clients:

• Geth - 32000 🟢
• Besu - 32000 🟢
• Nethermind - 32603 🔴

Steps to Reproduce

Geth

• docker run --rm -p 8545:8545 ethereum/client-go:v1.11.5 --dev --http --http.addr 0.0.0.0

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x00"],"id":1}' -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":1,"error":{"code":-32000,"message":"filter not found"}}

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x01"],"id":2}' -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","id":2,"error":{"code":-32000,"message":"filter not found"}}

Besu

• docker run --rm -p 8545:8545 hyperledger/besu:23.1.0 --network=dev --rpc-http-enabled=true --rpc-http-host="0.0.0.0"

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x00"],"id":1}' -H "Content-Type: application/json" http://localhost:8545
{
  "jsonrpc" : "2.0",
  "id" : 1,
  "error" : {
    "code" : -32000,
    "message" : "Filter not found"
  }

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x01"],"id":2}' -H "Content-Type: application/json" http://localhost:8545
{
  "jsonrpc" : "2.0",
  "id" : 2,
  "error" : {
    "code" : -32000,
    "message" : "Filter not found"
  }
}

Nethermind

• docker run --rm -p 8545:8545 nethermind/nethermind:1.17.3 --config AuraTest --JsonRpc.Enabled true --JsonRpc.Host "0.0.0.0"

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x00"],"id":1}' -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","error":{"code":-32603,"message":"Filter with id: '0' does not exist."},"id":1}

$ curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getFilterChanges","params":["0x01"],"id":2}' -H "Content-Type: application/json" http://localhost:8545
{"jsonrpc":"2.0","error":{"code":-32603,"message":"Filter with id: '1' does not exist."},"id":2}

Actual behavior

• Nethermind client

{
  "error": {
    "code": -32603,
    "message": "Filter with id: '0' does not exist."
  },
  [...]
}

Expected behavior

• Other Ethereum clients

{
    "error": {
        "code": -32000,
        "message": "Filter not found"
    },
    [...]
}

Desktop

• Operating System: Linux - Ubuntu
• Installation Method: Docker
• Nethermind@1.17.3 (2023-03-28 latest)

Additional context

• Resources
  • https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getfilterchanges
  • https://ethereum.github.io/execution-apis/api-documentation/
    • ^0x([1-9a-f]+[0-9a-f]*|0)$