Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_block no longer returns miner records #4616

Closed
tjayrush opened this issue Sep 22, 2022 · 2 comments · Fixed by #5054
Closed

trace_block no longer returns miner records #4616

tjayrush opened this issue Sep 22, 2022 · 2 comments · Fixed by #5054
Assignees

Comments

@tjayrush
Copy link

The same behaviour happens on Erigon (please see this issue: erigontech/erigon#5462).

While it is true that the miner no longer receives a reward for mining the block, theeth_getBlockByNumber routine continues to return a miner field. (In the case illustrated in the referenced issue, "miner": "0x57865ba267d48671a41431f471933aec32a7c7d1").

For our application, we use trace_block to find "every appearance of every address anywhere on the chain". By removing the miner from trace_block post-merge, the node now requires that we call the RPC twice for each block. Once (against trace_block) for all the regular address and once (against eth_getBlockByNumber) for the miner. This doubles our processing time when indexing the entire chain.

@MarekM25 MarekM25 self-assigned this Oct 21, 2022
@deffrian deffrian linked a pull request Dec 25, 2022 that will close this issue
9 tasks
@LukaszRozmej
Copy link
Member

@tjayrush Question mark does it makes sense to be included there as a 0 value reward? I am in doubt it does. The miner still does get all the fees so it should be there. I see that Erigon implemented it, though that doesn't make it right thing to do.

@tjayrush
Copy link
Author

There's a positive reason to keep it as it reports addresses that are "involved: in the block even if there is no reward. Our application wants every appearance of every address. This is one of them.

What's the justification for removing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants