mergeTest expects objects to be equal which is the same object

[drager]

Hi!

This line:

falcor-router/test/unit/internal/jsongMerge.spec.js

Line 228 in 3b3a6a8

expect(cache).to.deep.equals(expected);

will always be true because its the same object. Lodash _.merge() changes and returns the object which makes them the same.

  var expected = _.merge(cache, jsong.jsonGraph);
  console.log(cache === expected); // true

  var out = jsongMerge(cache, jsong);
  expect(cache).to.deep.equals(expected);

If you change the method to this:

  var expected = _.merge(_.clone(cache), jsong.jsonGraph);
  console.log(cache === expected); // false

  var out = jsongMerge(cache, jsong);
  expect(cache).to.deep.equals(expected);

Then two of the tests will fail.

[drager]

So is this expected jsong here: https://github.com/Netflix/falcor-router/blob/master/test/unit/internal/jsongMerge.spec.js#L122-L135 correct or are you expecting wrong? Is the test wrong or is it the jsonMerge() method that are not working as intended?