fix(error hook): Error hook will only pass error object

Per @jhusain - we don't need to pass the path values because in some cases there won't be any and in most cases we've already logged those elsewhere.

BREAKING CHANGE: error hook arguments have changes. Now only the error itself is passed, not the path information.

Author: benlesh

src/router/call.js

@@ -79,6 +79,6 @@ module.exports = function routerCall(callPath, args,
             });
     })
     .do(null, function errorHookHandler(err) {
-      router._errorHook(callPath, err);
+      router._errorHook(err);
     }));
 };

src/run/conversion/noteToJsongOrPV.js

@@ -37,7 +37,7 @@ function convertNoteToJsongOrPV(pathOrPathSet,
         incomingJSONGOrPathValues =
             errorToPathValue(note.error, pathOrPathSet);
 
-        routerInstance._errorHook(pathOrPathSet, note.error);
+        routerInstance._errorHook(note.error);
     }
 
     // If its jsong we may need to optionally attach the

test/unit/core/call.spec.js

@@ -202,10 +202,7 @@ describe('Call', function() {
             call(['videos', 1234, 'rating'], [5]).
             do(noOp, function(err) {
                 expect(callCount).to.equal(1);
-                expect(callArgs).to.deep.equal([
-                    ['videos', 1234, 'rating'],
-                    err
-                ]);
+                expect(callArgs).to.deep.equal([err]);
                 expect(callContext).to.equal(router);
             }).
             subscribe(noOp, doneOnError(done), errorOnCompleted(done));

test/unit/core/get.spec.js

@@ -722,7 +722,6 @@ describe('Get', function() {
               function () {
                   expect(callCount).to.equal(1);
                   expect(callArgs).to.deep.equal([
-                      ['videos', 1, 'title'],
                       new Error('bad luck for you')
                   ]);
                   expect(callContext).to.equal(router);

test/unit/core/set.spec.js

@@ -261,7 +261,7 @@ describe('Set', function() {
       })
       .do(function() {
           expect(errorHook.callCount).to.equal(1);
-          expect(errorHook.calledWith(['im', 'a', 'route', 'yo'], new Error('error lawl'))).to.be.ok;
+          expect(errorHook.calledWith(new Error('error lawl'))).to.be.ok;
       })
       .subscribe(noOp, done, done);
     });