-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom templates for nf-x-axis and nf-y-axis are not working #106
Comments
This addon doesn't currently support Ember 1.13. There are some APIs that were dropped in that version that his library relied on. |
@Blesh I was just hit by this as well. I don't think it's limited to 1.13. |
@jasonkriss what version of Ember are you using? |
@Blesh I'm on 2.0.0. |
@jasonkriss yeah, this addon won't work with 1.13 or higher. 1.13 broke compatibility with a couple of little-used (but not private) APIs these components used. My team at Netflix needs this addon to keep supporting 1.11 and 1.12, since that's the version our apps are on, and given how daunting the refactor looks to make it to 2.0, we're unlikely to invest much time to upgrade this addon to support 1.13 and higher at least for the time being. Anyone is welcome to create PRs to add 2.0 support, of course, and I'll happily merge them if they don't break support for 1.11 and 1.12. |
FWIW: I've added a jj-abrams branch for anyone that wants to try their hand at supporting 2.0. |
@Blesh got it! Thanks for providing a lil more context. |
I'm running Ember 1.13 and custom templates are not working. As mentioned in this comment (64e657c#commitcomment-12000510),
hasBlock
andhasBlockParams
are available only in the template, so theuseTemplate
property is not computed correctly.The text was updated successfully, but these errors were encountered: