Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom templates for nf-x-axis and nf-y-axis are not working #106

Closed
andrei1089 opened this issue Sep 17, 2015 · 7 comments
Closed

Custom templates for nf-x-axis and nf-y-axis are not working #106

andrei1089 opened this issue Sep 17, 2015 · 7 comments

Comments

@andrei1089
Copy link

I'm running Ember 1.13 and custom templates are not working. As mentioned in this comment (64e657c#commitcomment-12000510), hasBlock and hasBlockParams are available only in the template, so the useTemplate property is not computed correctly.

@benlesh
Copy link
Contributor

benlesh commented Sep 17, 2015

This addon doesn't currently support Ember 1.13. There are some APIs that were dropped in that version that his library relied on.

@benlesh benlesh closed this as completed Sep 17, 2015
@jasonkriss
Copy link

@Blesh I was just hit by this as well. I don't think it's limited to 1.13. hasBlock and hasBlockParams are only available in templates contexts.

@benlesh
Copy link
Contributor

benlesh commented Sep 29, 2015

@jasonkriss what version of Ember are you using?

@jasonkriss
Copy link

@Blesh I'm on 2.0.0.

@benlesh
Copy link
Contributor

benlesh commented Sep 29, 2015

@jasonkriss yeah, this addon won't work with 1.13 or higher. 1.13 broke compatibility with a couple of little-used (but not private) APIs these components used. My team at Netflix needs this addon to keep supporting 1.11 and 1.12, since that's the version our apps are on, and given how daunting the refactor looks to make it to 2.0, we're unlikely to invest much time to upgrade this addon to support 1.13 and higher at least for the time being.

Anyone is welcome to create PRs to add 2.0 support, of course, and I'll happily merge them if they don't break support for 1.11 and 1.12.

@benlesh
Copy link
Contributor

benlesh commented Sep 29, 2015

FWIW: I've added a jj-abrams branch for anyone that wants to try their hand at supporting 2.0.

@jasonkriss
Copy link

@Blesh got it! Thanks for providing a lil more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants