Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Inline tasks implementation is broken - the validations are incorrectly implemented #2565

Closed
boney9 opened this issue Nov 9, 2021 · 0 comments
Labels
type: bug bugs/ bug fixes

Comments

@boney9
Copy link
Contributor

boney9 commented Nov 9, 2021

Describe the bug
Inline tasks implementation is broken - the validations are incorrectly implemented. The validations intends to check for whether the evaluationType or expression is blank, but instead its checking for isNotBlank. There are no tests for the new inline task implementation either.

Details
Conductor version: Latest
Persistence implementation: NA
Queue implementation: NA
Lock: NA
Workflow definition: NA
Task definition: NA
Event handler definition: NA

To Reproduce
Steps to reproduce the behavior:

  1. Implement an INLINE task and try to run it
  2. Fails with the validation error even if the required params are missing

Expected behavior
Validations should be implemented correctly

Screenshots
NA

Additional context
NA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug bugs/ bug fixes
Projects
None yet
Development

No branches or pull requests

1 participant