Javanica threadpool properties per class are applied to all thread pools

[john-roj]

On our project we have 2 classes Annotated with @HystrixCommand

public class SomeService {

     @HystrixCommand(
        ignoreExceptions = { NonSevereClientException.class },
        commandProperties = {
            @HystrixProperty(name = "execution.isolation.thread.timeoutInMilliseconds", value = 5000)
        },
        threadPoolProperties = {
            @HystrixProperty(name = "coreSize", value = 75,
            @HystrixProperty(name = "maxQueueSize", value = 5)
        })
        public Response getAll(Long someParam) {}  ...

The other class uses defaults for thread pool properties:

public class SomeOtherService {

     @HystrixCommand(
        ignoreExceptions = { NonSevereClientException.class },
        commandProperties = {
            @HystrixProperty(name = "execution.isolation.thread.timeoutInMilliseconds", value = 5000)
        }
        public Response getStuff() {}  ...

However when we check the Dashboard both thread pools have poolSize set to 75.

Is this expected?

[dmgcodevil]

Hi,
I don't think that it's correct behavior, could you try to specify specific thread pool name using threadPoolKey property of HystrixCommand annotation and see what happen ?

@HystrixCommand(threadPoolKey="thp1")
public Response getAll(Long someParam) {} 

@HystrixCommand(threadPoolKey="thp2")
public Response getStuff() {} 

Thanks

[john-roj]

Well adding the threadPoolKey seems to have worked... I am wondering if it is indeed a bug and this is a workaround.

Thanks

[dmgcodevil]

it looks like a bug, currently I'm working on #907 bug and at the same time will check this one

[dmgcodevil]

Actually we have the tests to check command properties including threadPoolKey and it works well: test, I've added more tests but failed to reproduce the issue.
@john-roj87 what javanica version are you using, also could you write a test that reproduces the issue ?

[dmgcodevil]

Ok, I found root cause of the issue, actually it's the same for #782 and should be fixed altogether

[dmgcodevil]

@mattrjacobs hi, you can close it

[lingyejun]

you can set tomcat's max-thread to solve the question.
e.g server.tomcat.max-threads=200