Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger.error not logger.debug for fallback failure #12

Closed
benjchristensen opened this issue Nov 27, 2012 · 1 comment
Closed

Use logger.error not logger.debug for fallback failure #12

benjchristensen opened this issue Nov 27, 2012 · 1 comment
Milestone

Comments

@benjchristensen
Copy link
Contributor

Change the following line to use logger.error:
https://github.com/Netflix/Hystrix/blob/master/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommand.java#L1355

Even though the Throwable is captured inside HystrixRuntimeException most code handling the exception is not capable of inspecting it thus it becomes very hard in production operations to determine why a fallback fails.

It should be very rare that a fallback fails (the point of fallback is to do something that can't fail) but when it does it's difficult to track down right now.

@benjchristensen
Copy link
Contributor Author

Completed in commit 5cdbf70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant