Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ngi_user_info.yml not updating correctly #114

Closed
Olzeke51 opened this issue Jul 7, 2024 · 1 comment · Fixed by #115
Closed

[BUG] ngi_user_info.yml not updating correctly #114

Olzeke51 opened this issue Jul 7, 2024 · 1 comment · Fixed by #115
Assignees
Labels
bug Something isn't working

Comments

@Olzeke51
Copy link

Olzeke51 commented Jul 7, 2024

Description

voiced Neon that my first name is Gary.
Could never get a response from Neon.
nmi_user_info.yml added some stuff to my name

Steps to Reproduce

fresh install of 7.5b40, voiced my location, voiced my timezone
later did a voiced 'my first name is Gary'
when queried - got no response -- by voice or mana.....
edited miscellaneous characters in my name
Works Now.....

Relevant Code

this is the original::

(venv) neon@neon:~$ cat .config/neon/ngi_user_info.yml
user:
  first_name: ''
  middle_name: ''
  last_name: ''

this is the modified by voice: [extra stuff after 'Gary'

(venv) neon@neon:~$ cat .config/neon/ngi_user_info.yml
user:
  first_name: Gary . "   <<< this is what voice input created,
                         <<< could not get a voice/txt answer 
                         <<< 'what is my first name' 
                         **** did get an answer to 'my location' !!!!
  middle_name: ''
  last_name: ''
  preferred_name: ''
  full_name: Gary . "
  dob: YYYY/MM/DD

Other Notes

bad_ngi-logs.tar.gz

@Olzeke51 Olzeke51 added bug Something isn't working triage New issue needs review labels Jul 7, 2024
@NeonDaniel NeonDaniel removed the triage New issue needs review label Jul 9, 2024
@NeonDaniel
Copy link
Member

It looks like STT in this case added punctuation which usually shouldn't happen. Two places we could handle this:

  1. In the personal skill, clean any non-alpha characters from the configured name
  2. In the user-settings skill, clean any non-alpha characters before saving the recorded name to configuration

My inclination is to normalize things going INTO configuration, but checking it here could also help catch weird configuration values since that can be changed outside of the settings skill too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants