From 7abf18f7b9082ef871e653b02bc426d9808dbf26 Mon Sep 17 00:00:00 2001 From: Daniel McKnight Date: Thu, 15 Jun 2023 15:29:23 -0700 Subject: [PATCH 1/2] Deprecate create_skill method and Update __init__ for best practices --- __init__.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/__init__.py b/__init__.py index 35ebf0e..ec8525c 100644 --- a/__init__.py +++ b/__init__.py @@ -48,10 +48,9 @@ from neon_utils.message_utils import get_message_user -class UsbCamSkill(NeonSkill): - - def __init__(self): - super(UsbCamSkill, self).__init__(name="Camera") +class CameraSkill(NeonSkill): + def __init__(self, **kwargs): + NeonSkill.__init__(self, **kwargs) self.pic_path = os.path.expanduser("~/Pictures/Neon") self.vid_path = os.path.expanduser("~/Videos/Neon") os.makedirs(self.pic_path, exist_ok=True) @@ -92,6 +91,7 @@ def runtime_requirements(self): no_network_fallback=True, no_gui_fallback=True) + # TODO: Move to __init__ after stable ovos-workshop def initialize(self): # Uses `duration` from mycroft-timer skill self.register_entity_file('duration.entity') @@ -358,7 +358,3 @@ def ensure_dir(file_path): def stop(self): self.handle_camera_completed() - - -def create_skill(): - return UsbCamSkill() From f69591764a784959ffe2d882d4d0dcda335e187f Mon Sep 17 00:00:00 2001 From: Daniel McKnight Date: Thu, 15 Jun 2023 15:46:24 -0700 Subject: [PATCH 2/2] Skip OSM tests --- .github/workflows/skill_tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/skill_tests.yml b/.github/workflows/skill_tests.yml index 06261a9..23f1520 100644 --- a/.github/workflows/skill_tests.yml +++ b/.github/workflows/skill_tests.yml @@ -16,3 +16,5 @@ jobs: # uses: neongeckocom/.github/.github/workflows/skill_test_resources.yml@master skill_install_tests: uses: neongeckocom/.github/.github/workflows/skill_test_installation.yml@master + with: + test_osm: False \ No newline at end of file