Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property panels of PyPlug's nodes cannot be closed or fully inspected #449

Closed
Vhati opened this issue Jan 12, 2020 · 5 comments
Closed

Property panels of PyPlug's nodes cannot be closed or fully inspected #449

Vhati opened this issue Jan 12, 2020 · 5 comments
Labels
difficulty:easy Easy-to-solve bug func:gui prio:low type:bug Something isn't working ver:2.x
Milestone

Comments

@Vhati
Copy link

Vhati commented Jan 12, 2020

Problem

A PyPlug's nested nodes are ostensibly locked and inaccessible. Yet they can be double-clicked, creating an unclosable properties panel.

Steps to Reproduce

  • Add a Lightning node.
  • In the node properties header bar, click the eye button (5th from the right) to "show the underlying node graph."
  • They'll be shown, and the graph will be locked (grayed out).
  • Double-click on one of the nested nodes to get its properties. (Yes, that's allowed.)
  • Its properties panel will appear. It will not respond to clicks... including the "X" to dismiss it.
  • To get rid of the properties, you need to unlock the graph (converting the PyPlug into a regular group) to make the "X" work.

Versions

Official Natron 2.3.14 on Win 7

@Vhati Vhati changed the title A PyPlug's locked node graph can be double-clicked while locked A PyPlug's node graph can be double-clicked while locked Jan 12, 2020
@devernay
Copy link
Member

You can also use the "close all panels" button (white cross in the image below)
image

I think it's OK to open these properties panels, in order to inspect the PyPlug's content, but one should be able to:

  • select different tabs to inspect these (Controls/Node/Info) - the contents of each tab should be disabled
  • click any on the five leftmost buttons in the titlebar (which do not modify the node's properties)

image

@devernay devernay added this to the 2.4 milestone Jan 12, 2020
@devernay devernay added difficulty:easy Easy-to-solve bug func:gui prio:low type:bug Something isn't working ver:2.x labels Jan 12, 2020
@devernay devernay changed the title A PyPlug's node graph can be double-clicked while locked Property panels of PyPlug's nodes cannot be closed or fully inspected Jan 12, 2020
@splidje
Copy link
Contributor

splidje commented Jan 12, 2020

Where do I get the Lightning node to try this?

@splidje
Copy link
Contributor

splidje commented Jan 12, 2020

Actually, I can reproduce this with any PyPlug. Should have tried that before posting before!

@devernay
Copy link
Member

Yes, use Lightwrap (which is what I did)

@splidje
Copy link
Contributor

splidje commented Jan 14, 2020

I believe this fixes it:
#452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy Easy-to-solve bug func:gui prio:low type:bug Something isn't working ver:2.x
Projects
None yet
Development

No branches or pull requests

3 participants