Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not package 64 bit libraries #297

Closed
blagoev opened this issue Dec 10, 2015 · 9 comments
Closed

Do not package 64 bit libraries #297

blagoev opened this issue Dec 10, 2015 · 9 comments

Comments

@blagoev
Copy link
Contributor

blagoev commented Dec 10, 2015

Currently android runtime is 32bit only on arm and x86. When a plugin brings its own native library it might contain 64bit builds. This is quite possible since most libraries authors are advised to support all ABIs available.
When Android installs the application it checks for the existence of any 64bit library in the package and marks the application as 64 bit compatible. This requires all other libraries to provide 64bit versions of their so files.

One possible fix is to not package any 64bit native libraries in the final application package. (until we provide 64bit versions of the runtime)

This is related:
NativeScript/nativescript-marketplace-demo#84

@atanasovg atanasovg added this to the 1.6.0 (Under review) milestone Jan 4, 2016
@atanasovg
Copy link
Contributor

ping @teobugslayer This is of high importance until we have 64-bit version of the runtime.

@slavchev
Copy link

Additionally, #330 provides runtime binaries for ARM64.

@blagoev
Copy link
Contributor Author

blagoev commented Jan 11, 2016

now that we have arm64 we should think how we are packaging the application. Are we going to include this in the package or we will provide a flag in the CLI to optionally enable this?

also if some plugin is 32bit only the app will fail if we package any 64bit lib in the apk so we need to stop the build with an error and warn the user

@NathanaelA

This comment was marked as abuse.

@slavchev
Copy link

Thanks @NathanaelA

Here is an interesting comment facebook/react-native#2814 (comment) discussing the same topic. That guy @corbt has a blog post as well.

@NathanaelA

This comment was marked as abuse.

@blagoev
Copy link
Contributor Author

blagoev commented Jan 13, 2016

The guidance from Google is to use multiple apks when the apk gets over 50MB in size.

@teobugslayer
Copy link

I have created a separate issue with another approach of dealing with this problem: NativeScript/nativescript-cli#1392 Please comment!

@atanasovg
Copy link
Contributor

Let's use the issue @teobugslayer created. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants