fix: latest NDK

BREAKING CHANGE: minSDK is now 21

Author: farfromrefug

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

package.json

@@ -14,8 +14,8 @@
     "gradle": "8.4",
     "gradleAndroid": "8.3.2",
     "ndk": "r23c",
-    "ndkApiLevel": "17",
-    "minSdk": "17",
+    "ndkApiLevel": "21",
+    "minSdk": "21",
     "compileSdk": "34",
     "buildTools": "34.0.0",
     "kotlin": "2.0.0"

test-app/gradle.properties

@@ -21,7 +21,7 @@ android.useAndroidX=true
 # Default versions used throughout the gradle configurations
 NS_DEFAULT_BUILD_TOOLS_VERSION=34.0.0
 NS_DEFAULT_COMPILE_SDK_VERSION=34
-NS_DEFAULT_MIN_SDK_VERSION=17
+NS_DEFAULT_MIN_SDK_VERSION=21
 NS_DEFAULT_ANDROID_BUILD_TOOLS_VERSION=8.3.2
 
 ns_default_androidx_appcompat_version = 1.6.1

test-app/runtime/CMakeLists.txt

@@ -20,6 +20,9 @@ MESSAGE(STATUS "## ANDROID_NDK_ROOT: " ${ANDROID_NDK_ROOT})
 
 set(COMMON_CMAKE_ARGUMENTS "-std=c++17 -Werror -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy -fno-rtti -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_EMBEDDED_BUILTINS")
 
+#enable support for devices that use a 16KiB page size (https://developer.android.com/guide/practices/page-sizes)
+set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON")
+
 if("${ANDROID_ABI}" MATCHES "arm64-v8a$" OR "${ANDROID_ABI}" MATCHES "x86_64$")
     # Enable pointer compression on 64 bit platforms
     set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -DV8_COMPRESS_POINTERS")
@@ -178,8 +181,8 @@ target_link_libraries(NativeScript ${PROJECT_SOURCE_DIR}/src/main/libs/${ANDROID
 if("${ANDROID_ABI}" MATCHES "armeabi-v7a$" OR "${ANDROID_ABI}" MATCHES "x86$")
     # On API Level 19 and lower we need to link with android_support
     # because it contains some implementation of functions such as "strtoll" and "strtoul"
-    MESSAGE(STATUS "# Linking with libandroid_support.a")
-    target_link_libraries(NativeScript ${ANDROID_NDK_ROOT}/sources/cxx-stl/llvm-libc++/libs/${ANDROID_ABI}/libandroid_support.a)
+    #MESSAGE(STATUS "# Linking with libandroid_support.a")
+    #target_link_libraries(NativeScript ${ANDROID_NDK_ROOT}/sources/cxx-stl/llvm-libc++/libs/${ANDROID_ABI}/libandroid_support.a)
 endif()
 
 # Command info: https://cmake.org/cmake/help/v3.4/command/find_library.html