include interpolation weights in DFT slice output #787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that empty dimensions are collapsed correctly. I think this should fix #784 — what was happening is that at "unlucky" resolutions where the DFT slice fell between two pixels, the
collapse_empty_dims
was summing over two pixels in the empty direction, but without the interpolation weights this effectively doubled the field value, resulting in the factor-of-two oscillation observed in #784.One downside of this PR is that, at the edges of the output volume, the edge pixels might be multiplied by an integration weight factor (between 0 and 1). It might be nice to only include the interpolation weights for empty dimensions, but not for edge pixels, but that would require some additional work (e.g. a differentUpdate: Now the PR only includes the empty-dimension interpolation weights, and not the edge integration weights.IVEC_LOOP_WEIGHT
function or a modifiedloop_in_chunks
).