Refactor interfaces and internal state of adjoint module objective quantities #1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up where #1588 left off with some refactoring of the
mpa.ObjectiveQuantity
child classes:mpa.ObjectiveQuantity
child classes are not correctly indicated as being privatempa.ObjectiveQuantity
child classes (e.g.source
inEigenmodeCoefficient
) should apparently not even be part of the internal state (since they're unused) and are initialized in an adhoc manner throughout different methods of the classesadj_src_scale()
andcreate_time_profile()
should actually be methods ofmpa.ObjectiveQuantity
In an effort to streamline the process of debugging tricky issues such as #1585, the interfaces, attributes, and data marshaling in the adjoint module should be standardized in the
mpa.ObjectiveQuantity
.