-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbosity improvements #1388
Verbosity improvements #1388
Conversation
… test code to a unittest module.
NOTE: After playing with and testing this change for a couple days I'm not so sure that the feature of setting verbosity.meep = 2
verbosity.mpb = 3
a_solver.run_te() Since the |
It should only be done in |
Okay. I've reverted the applicable changes in |
* Add ability to access verbosity values by name (as a property), moved test code to a unittest module. * Add RAII class to temporarily set mpb_verbosity to meep's verbosity-1 * Make MPB's version available from Python * Use adjust_mpb_verbosity in mpb.cpp and pympb.cpp at strategic points * Update comments and some cleanup * Remove some debug printf's * Switch most mpb_verbosity checks to be >=1 * Switch verbosity checks in Python code to verbosity.meep or verbosity.mpb * Revert use of adjust_mpb_verbosity in pympb, add a couple more in mpb * adjust_verbosity.h does not need to be #included here any longer
Fixes #1362
See also NanoComp/mpb#125
Verbosity
classverbosity.meep
orverbosity.mpb
meep.mpb
packagempb_verbosity
tomeep::verbosity - 1
mpb_verbosity
checks to>=1
, to be closer to the original intent of the new verbosity functionalityVerbosity
class