Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model binding callback signature (to avoid updating DOM if that's wh... #29

Merged
merged 1 commit into from
Dec 4, 2012

Conversation

KidkArolis
Copy link
Contributor

...ere the model change originated)

Do you guys want a test? Wasn't sure what kind of test would be appropriate.

@KidkArolis
Copy link
Contributor Author

Fixes #15

@delambo delambo merged commit 32ab9ac into nytimes:master Dec 4, 2012
@delambo
Copy link
Member

delambo commented Dec 4, 2012

@KidkArolis This is a tough one to test since it has to do with the cursor position while typing. Thanks for troubleshooting and submitting the fix!

@KidkArolis
Copy link
Contributor Author

Unit testing smaller functions could help, but that would require splitting stickit() function into smaller functions.

@delambo
Copy link
Member

delambo commented Dec 4, 2012

Yeah, we have been adding too much code, without refactoring. But even after splitting up the code it would be hard to unit test more than the api because of the closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants