Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Reconcile differences from CUDF's row_conversion.cu #1149

Closed
mythrocks opened this issue May 17, 2023 · 1 comment
Closed

[BUG] Reconcile differences from CUDF's row_conversion.cu #1149

mythrocks opened this issue May 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mythrocks
Copy link
Collaborator

CUDF JNI has a copy of row_conversion.cu that has a couple of material differences from the version in spark-rapids-jni. (The changes have to do with which stream is used when constructing a LIST column, the use of cudaMemcpyDefault, etc.)

It would be good to review those differences, and reconcile them before row_conversion.cu is removed from CUDF JNI.
@mythrocks mythrocks added bug Something isn't working ? - Needs Triage labels May 17, 2023
@mythrocks mythrocks mentioned this issue May 17, 2023
Closed
@ttnghia
Copy link
Collaborator

ttnghia commented Dec 21, 2023

Code of row_conversion was moved into libcudf in rapidsai/cudf#14664, and the version in cudf's JNI was removed. From now, there is just one version of row_conversion so close this.

@ttnghia ttnghia closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattahrens @mythrocks @ttnghia