Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Link pointing to Thrust Development Model in CONTRIBUTING.md is invalid (gives 404) #447

Closed
kshitij12345 opened this issue Mar 24, 2022 · 4 comments · Fixed by #449
Closed
Labels
good first issue Good for newcomers. only: docs Documentation changes only. Doesn't need code CI. P1: should have Necessary, but not critical. type: bug: functional Does not work as intended.
Milestone

Comments

@kshitij12345
Copy link
Contributor

Ref: https://github.com/NVIDIA/cub/blob/main/CONTRIBUTING.md#development-model

@alliepiper alliepiper added only: docs Documentation changes only. Doesn't need code CI. type: bug: functional Does not work as intended. P1: should have Necessary, but not critical. good first issue Good for newcomers. labels Mar 24, 2022
@alliepiper alliepiper added this to the 1.17.0 milestone Mar 24, 2022
@alliepiper
Copy link
Collaborator

Thanks for pointing this out! The Thrust docs were reorganized recently and we missed this.

This link should point to https://github.com/NVIDIA/thrust/blob/main/docs/github_pages/releases/versioning.md.

@kshitij12345
Copy link
Contributor Author

kshitij12345 commented Mar 24, 2022

Should the PR be on this repo or thrust? Sorry I am a bit confused. Thanks!

EDIT: Nevermind. I think I figured it out :)

@kshitij12345
Copy link
Contributor Author

kshitij12345 commented Mar 24, 2022

Also, link to CONTRIBUTING.md of thrust is invalid (couldn't find CONTRIBUTING.md in the thrust repo)

Ref: https://github.com/NVIDIA/cub/blob/main/CONTRIBUTING.md#contributing-to-cub

@alliepiper
Copy link
Collaborator

Great, thanks for the PR :)

On second thought, we should probably link to the new formatted docs rather than the markdown files. Can you update #449 so that:

  1. "development model" link goes to https://nvidia.github.io/thrust/releases/versioning.html
  2. "contributing" link goes to https://nvidia.github.io/thrust/contributing.html

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers. only: docs Documentation changes only. Doesn't need code CI. P1: should have Necessary, but not critical. type: bug: functional Does not work as intended.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants