adding support for gelu converter in activation.cpp #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruoqian Guo <ruoqiang@nvidia.com>
|
@peri044 did you have a chance to think about the way we do plugins? I think there were a few issues with how the other PR did it. We should probably work on a formal solution this week to support this PR. |
narendasan
added
the
on hold
Signed-off-by: Ruoqian Guo <ruoqiang@nvidia.com>
|
I believe this is handled in #385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruoqian Guo ruoqiang@nvidia.com
Description
Adding support for gelu converter in activation.cpp
I referenced this PR #285 .
Fixes #269
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: