UnmetLoadHoursTroubleshooting measure should handle failures more gracefully

[jmarrec]

User on https://unmethours.com/question/100084/cannot-run-unmet-load-hours-troubleshooting-measure/

AirLoopHVAC does not have a setpoint manager on the supply outlet node, so it crashes here:

openstudio-common-measures-gem/lib/measures/UnmetLoadHoursTroubleshooting/measure.rb

Lines 162 to 165 in 6f3a818

	loopName = airloop.name.to_s
	supplyOutletNode = airloop.supplyOutletNode
	setPointManagers = supplyOutletNode.setpointManagers
	type = setPointManagers[0].iddObjectType.valueDescription

[jmarrec]

After adjusting the SPMs, the measure will throw here, because the name has comas and the SQL query fails.

openstudio-common-measures-gem/lib/measures/UnmetLoadHoursTroubleshooting/measure.rb

Lines 590 to 591 in 6f3a818

	zoneMetrics[:zone_mean_air_temp_vals] = getTimeSeries('Zone Mean Air Temperature', zone_name.upcase, @annEnvPd, 'Hourly')
	zoneMetrics[:zone_mean_air_temp_vals].map! { |v| OpenStudio.convert(v, 'C', 'F').get }

No data found for 'Zone Mean Air Temperature' 'THERMAL ZONE: 2FL_OFFICE203,204,205' 
SWIG director method error. NoMethodError: undefined method map!' for nil:NilClass
Traceback (most recent call last): /tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:591:ininitZoneMetric

---

Then if I fix this, it fails on

Making time series for envPeriod = 'RUN PERIOD 1', reportingFrequency = 'Hourly', timeSeriesName = 'Zone People Occupant Count', keyValue = 'THERMAL ZONE: ELEVATOR2'
Tuple: RUN PERIOD 1, Hourly, Zone People Occupant Count, THERMAL ZONE: ELEVATOR2 not found in data dictionary.
No time series found
No data found for 'Zone People Occupant Count' 'THERMAL ZONE: ELEVATOR2'

SWIG director method error. NoMethodError: undefined method `getDesignLoopExitTemperature' for #<OpenStudio::Model::SizingPlant:0x00007f11f2028040 @__swigtype__="_p_openstudio__model__SizingPlant">
Traceback (most recent call last):
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:261:in `block in plant_loop_temp_vs_setpoints'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:244:in `each'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:244:in `plant_loop_temp_vs_setpoints'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:528:in `run'
Found error in state 'ReportingMeasures' with message: 'Runner error: Measure '/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb' reported an error with [SWIG director method error. NoMethodError: undefined method `getDesignLoopExitTemperature' for #<OpenStudio::Model::SizingPlant:0x00007f11f2028040 @__swigtype__="_p_openstudio__model__SizingPlant">
Traceback (most recent call last):
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:261:in `block in plant_loop_temp_vs_setpoints'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:244:in `each'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:244:in `plant_loop_temp_vs_setpoints'
/tmp/osmodel-c616-91e0-d2d2-bb62-1727164398-0/resources/measures/UnmetLoadHoursTroubleshooting/measure.rb:528:in `run']'

The proper SizingPlant getter is double designLoopExitTemperature() const. https://github.com/NREL/OpenStudio/blob/ba1b94b6542c1f1d4cdcdb775886852b9a82bc4f/src/model/SizingPlant.hpp#L53

I'm not sure when the Quantity getDesignLoopExitTemperature() was removed in 3.0.0

https://github.com/NREL/OpenStudio/blob/58ed43d0b1d36eec28d167b1a82a4af9e0446c2a/openstudiocore/src/model/SizingPlant.hpp#L80

Edit:

• I see that Fix UnmetLoads measure for OS 3.0 and newer #168 actually fixes it