You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Working my way through PR #16, I noticed some problems on the HRRR interface.
When getting data from HRRR using wind_velocity_direction_at_altitude, at any height AGL height_above_ground above 100 m, we fall into the following else to get the appropriate pressure level:
where ground_level_m is used as an argument to nearest_pressures. However, oftentimes the call to wind_velocity_direction_at_altitude does not include ground_level_m, but rather height_above_ground_m. The ground_level_m is zero by default:
so I'm not sure if it is appropriate to use height_above_ground_m
What should we use here? Not specifying ground_level_m does not work because of the default 0 (and would not even be appropriate). Should we first get the ground level and then combine it with the height AGL?
Right now, in the latest commit from PR #16, I replaced line 359 above with
Hi @rthedin, good catch. I think it should be ground_level_m + height_above_ground_m to give the altitude above sea level. However, I don't think we need to be too concerned about this because we need to rework nearest_pressures() anyway and--correct me if I'm wrong @rimplesandhu--I don't think this is currently used. I think we can use the hypsometric equation instead of a hard-coded lookup table.
Working my way through PR #16, I noticed some problems on the HRRR interface.
When getting data from HRRR using
wind_velocity_direction_at_altitude
, at any height AGLheight_above_ground
above 100 m, we fall into the followingelse
to get the appropriate pressure level:SSRS/ssrs/hrrr/hrrr.py
Lines 350 to 363 in a9114c7
where
ground_level_m
is used as an argument tonearest_pressures
. However, oftentimes the call towind_velocity_direction_at_altitude
does not includeground_level_m
, but ratherheight_above_ground_m
. Theground_level_m
is zero by default:SSRS/ssrs/hrrr/hrrr.py
Line 260 in a9114c7
According to the
nearest_pressures
function's docstring,h
is the height above sea level:SSRS/ssrs/hrrr/hrrr.py
Lines 92 to 93 in a9114c7
so I'm not sure if it is appropriate to use
height_above_ground_m
What should we use here? Not specifying
ground_level_m
does not work because of the default0
(and would not even be appropriate). Should we first get the ground level and then combine it with the height AGL?Right now, in the latest commit from PR #16, I replaced line 359 above with
SSRS/ssrs/hrrr/hrrr.py
Line 376 in 43a728f
However, I do understand that this is not really appropriate.
What would be appropriate path forward here?
The text was updated successfully, but these errors were encountered: