Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Failing Tests #4295

Closed
tijcolem opened this issue Apr 19, 2021 · 0 comments · Fixed by #4299
Closed

Geometry Failing Tests #4295

tijcolem opened this issue Apr 19, 2021 · 0 comments · Fixed by #4299

Comments

@tijcolem
Copy link
Collaborator

tijcolem commented Apr 19, 2021

There are a few failing measure tests on openstudio-model-articulation-gem which appear to be related to the recent Geometry changes in OpenStudio SDK and changes in surface area calculations. If you run these same tests with a 3.2.0-alpha previous installer before the Geometry branch was merged, they pass. 

Measure: create_bar_from_doe_building_type_ratios

Test that fail in create_bar_from_doe_building_type_ratios
test_dual_bar_1
test_dual_bar_101
test_non_zero_rotation_primary_school
test_dual_bar_11b
test_same_bar_both_ends

Steps to Reproduce

Install latest 3.2.0-alpha-412729e894 (with geometry pr)
3.2.0-alpha+B412729e894-Darwin.dmg
3.2.0-alpha+B412729e894-Ubuntu-18.04.deb
3.2.0-alpha+B412729e894-Windows.exe

Clone branch
git clone -branch openstudio_v3_2 https://github.com/NREL/openstudio-model-articulation-gem
cd openstudio-model-articulation-gem
Run measure test using CLI
openstudio --verbose measure -r /var/simdata/openstudio/openstudio-model-articulation-gem/lib/measures/create_bar_from_doe_building_type_ratios/

Here's a snipped output (full log attached) of one of the failing tests test_dual_bar_1. See under ERROR MESSAGES..

measure results for dual_bar_1
**MEASURE APPLICABILITY**
1 = Fail
**INITIAL CONDITION**
The building started with 0 spaces.
**FINAL CONDITION**
**INFO MESSAGES**
0.0 value for floor height will be replaced with smart default for SecondarySchool of 13.0.
0.0 value for window to wall ratio will be replaced with smart default for SecondarySchool of 0.33.
Creating Space Types for SecondarySchool.
Combining Classroom and Corridor into a group representing a double loaded corridor
Making bar with length of 387 ft and width of 129 ft
Intersecting and matching surfaces in model, this will create additional geometry.
Created bar envelope with floor area of 83,200 ft^2.
Ground exposed floor or Roof area is larger than footprint, likely inter-floor surface matching and intersection error, altering impacted surfaces boundary condition to be adiabatic.
**WARNING MESSAGES**
**ERROR MESSAGES**
SecondarySchool Classroom doesn't have the expected floor area (actual 29,155 ft^2, target 30,410 ft^2)
SecondarySchool Corridor doesn't have the expected floor area (actual 5,895 ft^2, target 21,440 ft^2)
Sum of actual floor area is 83199.96081004817 ft^2, sum of target floor area is 100000.0.

If you run the same measure using 3.2.0-alpha+74b17d8c16 (commit before Geometry merge), the tests all pass so it seems that something may have regressed with the recent change.  You can download those previous installers here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants