-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry Intersection Issue - Surface Shattering #3424
Comments
Trying to reproduce with 3.2.0 (OS App v1.2.0-rc6, more or less) Importing ShatterTest.json: empty model, go to Geometry Tab > Editor > FloorSpace > New > Open existing floorplan. THen just click "merge with current OSM" and look at results, showing story 1 only. For reference, Json looks like this: Test 1Test 2Test 3Test 4Probably fixed via #4221 |
This ticket touched on two issues, the surface 'shattering' behaviour, and the inconsistent geometry generation. Reading through #4221 there's a lot of great and interesting detail on resolving the shattering issue, but it seems to still be present, according to the above? |
@Mkellyeng I don't have your "large model" shown above AFAIK. Try it out with 3.2.0 and see if it improved. |
I dug up that original model and imported it into Open Studio 3.2, reran it. Still getting similar shattering behaviour. Interestingly you tell a few of the first spaces to be intersected, based on the intersection pattern (red circles) For reference I've attached the original json file, and the 3.2.0 .osm |
Summary: Intermittent intersection problem that erroneously subdivides many surfaces, and can cause parts of a surface to effectively be deleted.
If the intersection process would result in a surface having a hole, it uses some special logic to subdivide the surface, and thus avoid creating surfaces which otherwise couldn't be represented in EnergyPlus's coordinate format.
This works well in simple cases, however in larger buildings it can quickly cause some serious problems.
Intersections can have this special logic applied even when they wouldn't result in holes being created in the surface.
Attached are a series of testing files, a simple geometry was created in Floorspace and imported into OpenStudio. This was repeated twice with identical inputs and process. The result was two different .osm's, that when viewed in sketchup are seen to have different intersecting patterns. It seems as though what's happening is the two top level surfaces are being intersected in different orders each time. If the middle surface is checked first, we have a hole formed, like in the initial test case. However, if the edge surface is checked first, it is correctly intersected, after which point the middle surface will no longer create a hole.
ShatterTest01.png
ShatterTest02.png
In practice, this issue causes some serious problems. In addition to bloating the model with tonnes of unnecessary surface, this problem has, in the past, completely roadblocked the geometry creation process by creating geometries that could not be imported (hanging forever on import)
Would it be possible to have the intersection process resolve hole-creating surfaces last?
That is to say, before executing the special logic that protects against forming holes, take a note of the surface, and move on, then come back to it later after all other intersections are resolved?
Geometry Intersection Issue - Surface Shattering.zip
The text was updated successfully, but these errors were encountered: