Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Intersection Issue - Surface Shattering #3424

Closed
Mkellyeng opened this issue Feb 14, 2019 · 4 comments
Closed

Geometry Intersection Issue - Surface Shattering #3424

Mkellyeng opened this issue Feb 14, 2019 · 4 comments

Comments

@Mkellyeng
Copy link

Summary: Intermittent intersection problem that erroneously subdivides many surfaces, and can cause parts of a surface to effectively be deleted.

If the intersection process would result in a surface having a hole, it uses some special logic to subdivide the surface, and thus avoid creating surfaces which otherwise couldn't be represented in EnergyPlus's coordinate format.
hole_exception_demo

This works well in simple cases, however in larger buildings it can quickly cause some serious problems.
shattertest_example

Intersections can have this special logic applied even when they wouldn't result in holes being created in the surface.

Attached are a series of testing files, a simple geometry was created in Floorspace and imported into OpenStudio. This was repeated twice with identical inputs and process. The result was two different .osm's, that when viewed in sketchup are seen to have different intersecting patterns. It seems as though what's happening is the two top level surfaces are being intersected in different orders each time. If the middle surface is checked first, we have a hole formed, like in the initial test case. However, if the edge surface is checked first, it is correctly intersected, after which point the middle surface will no longer create a hole.

ShatterTest01.png
shattertest01

ShatterTest02.png
shattertest02

In practice, this issue causes some serious problems. In addition to bloating the model with tonnes of unnecessary surface, this problem has, in the past, completely roadblocked the geometry creation process by creating geometries that could not be imported (hanging forever on import)

Would it be possible to have the intersection process resolve hole-creating surfaces last?
That is to say, before executing the special logic that protects against forming holes, take a note of the surface, and move on, then come back to it later after all other intersections are resolved?

Geometry Intersection Issue - Surface Shattering.zip

@tanushree04 tanushree04 added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jul 21, 2020
@jmarrec jmarrec added component - Utilities Geometry severity - Normal Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 4, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented Jun 8, 2021

Trying to reproduce with 3.2.0 (OS App v1.2.0-rc6, more or less)

Importing ShatterTest.json: empty model, go to Geometry Tab > Editor > FloorSpace > New > Open existing floorplan. THen just click "merge with current OSM" and look at results, showing story 1 only.

For reference, Json looks like this:

image

Test 1

Test4

Test 2

image

Test 3

image

Test 4

image

Probably fixed via #4221

@jmarrec jmarrec closed this as completed Jun 8, 2021
@Mkellyeng
Copy link
Author

This ticket touched on two issues, the surface 'shattering' behaviour, and the inconsistent geometry generation.
Based on your 4 tests, it looks like the inconsistency has been resolved (awesome!), but the shattering behaviour is still present.

Reading through #4221 there's a lot of great and interesting detail on resolving the shattering issue, but it seems to still be present, according to the above?

@jmarrec
Copy link
Collaborator

jmarrec commented Jun 10, 2021

@Mkellyeng I don't have your "large model" shown above AFAIK. Try it out with 3.2.0 and see if it improved.

@jmarrec jmarrec self-assigned this Jun 10, 2021
@Mkellyeng
Copy link
Author

I dug up that original model and imported it into Open Studio 3.2, reran it. Still getting similar shattering behaviour.
image

Interestingly you tell a few of the first spaces to be intersected, based on the intersection pattern (red circles)
image

For reference I've attached the original json file, and the 3.2.0 .osm
Uploading Shattering Test - Large Model.zip…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants