Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless stuff in third_party folders #10343

Open
3 tasks
jmarrec opened this issue Dec 22, 2023 · 2 comments
Open
3 tasks

Remove useless stuff in third_party folders #10343

jmarrec opened this issue Dec 22, 2023 · 2 comments
Assignees
Labels
Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)

Comments

@jmarrec
Copy link
Contributor

jmarrec commented Dec 22, 2023

Issue overview

third_party folders are purposely not git submodules, so they should carry the source code, not all the things around it such as .github subfolders, etc. btwxt is definitely an offender, I don't know if there are any others.

Prompted by my git client constantly complaining (everytime I switch branches) that the courrier vendor googletest has no url: https://github.com/NREL/EnergyPlus/tree/develop/third_party/btwxt/vendor/courierr/vendor

image

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)

AFAIK, this was introduced in #10160

https://github.com/NREL/EnergyPlus/pull/10160/files#diff-9b605f18678db20624e8f2e9c98685f229f09906845df78a9f27a4ef861b9203

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@jmarrec jmarrec added the Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc) label Dec 22, 2023
@nealkruis nealkruis self-assigned this Dec 22, 2023
@nealkruis
Copy link
Member

I'll look into this. Most of these files can be removed as long as they are also ignored so they don't cause trouble for people developing them from their native repositories.

@jmarrec
Copy link
Contributor Author

jmarrec commented Jun 18, 2024

FYI I'm still hitting this on the daily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issue Related to cmake, packaging, installers, or developer tooling (CI, etc)
Projects
None yet
Development

No branches or pull requests

2 participants