Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add static variable support to preprocessor #685

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description

  • add checks for variable is_static=True before performing time-related query functions in the preprocessor
  • add logic to pp xarray concatenation procedure to check for static variables and concatenate along the Y,X,or N dimension

Associated issue #684

How Has This Been Tested?
RHEL 8, Python 3.12
WWEs POD

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

… query functions in the preprocessor

add logic to pp xarray concatenation procedure to check for static variables and concatenate along the Y,X,or N dimension
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Sep 11, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Sep 11, 2024
@wrongkindofdoctor wrongkindofdoctor merged commit 02a43c3 into NOAA-GFDL:main Sep 11, 2024
2 of 4 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the add_static_variable_support branch September 11, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant