Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug issues with preprocessor parsing pod settings file #682

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description
Include a summary of the change, and link the associated issue (if applicable).
List any dependencies that are required for this change, including libraries and variables,
and their metadata (units, frequencies, etc...). Be sure to separate PRs and issues for new PODs and PODs currently under development.

Associated issue #681

How Has This Been Tested?
RHEL8 , Python 3.12, WWEs POD (incoming)
Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

erileydellaripa and others added 30 commits August 19, 2024 13:30
Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking
Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Sep 10, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Sep 10, 2024
@@ -0,0 +1,506 @@
import numpy as np
import xarray as xr
import pandas as pd

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'pd' is not used.
import numpy as np
import xarray as xr
import pandas as pd
from netCDF4 import Dataset

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Dataset' is not used.
import xarray as xr
import pandas as pd
from netCDF4 import Dataset
import glob

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'glob' is not used.
import pandas as pd
from netCDF4 import Dataset
import glob
import os

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'os' is not used.
lon_index = np.where(np.asarray(data.dims) == 'lon')

w_wwe = np.where((bb_sizes[:, time_index] >= mintime) & (bb_sizes[:, lon_index] >= minlons))
n_wwe = np.count_nonzero((bb_sizes[:, time_index] >= mintime) &

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable n_wwe is not used.
import xarray as xr
import glob
import os
import time

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'time' is not used.
import glob
import os
import time
import xesmf as xe

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'xe' is not used.
import os
import time
import xesmf as xe
import scipy

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'scipy' is not used.
import time
import xesmf as xe
import scipy
from scipy import stats

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'stats' is not used.
Comment on lines +19 to +28
from WWE_diag_tools import (
land_mask_using_etopo,
regridder_model2obs,
nharm,
calc_raw_and_smth_annual_cycle,
isolate_WWEs,
WWE_characteristics,
WWE_statistics, #We don't need to do the statistics to make the likelihood by longitude plot
find_WWE_time_lon,
plot_model_Hovmollers_by_year)

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'land_mask_using_etopo' is not used.
Import of 'regridder_model2obs' is not used.
Import of 'nharm' is not used.
Import of 'calc_raw_and_smth_annual_cycle' is not used.
Import of 'isolate_WWEs' is not used.
Import of 'WWE_characteristics' is not used.
Import of 'WWE_statistics' is not used.
Import of 'find_WWE_time_lon' is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants