Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the modules loaded in ecf scripts against the job to ensure that they are used. Do this for all the jobs #587

Closed
aerorahul opened this issue Jan 16, 2022 · 3 comments
Closed

Check the modules loaded in ecf scripts against the job to ensure that they are used. Do this for all the jobs #587

aerorahul opened this issue Jan 16, 2022 · 3 comments
Assignees
@lgannoaa
Labels
help wanted Extra attention is needed implementation work Work for current implementation version

Comments

@aerorahul
Copy link
Contributor

In the operational ecf script for model forecast, CFP is loaded and set to be used. And so is grib_util.
See gdas, gfs and enkfgdsa scripts.

Verify that neither of those are used and remove the following from these:

module load cfp/${cfp_ver}
module load grib_util/${grib_util_ver}

and

export USE_CFP=YES
@aerorahul aerorahul added help wanted Extra attention is needed implementation work Work for current implementation version labels Jan 16, 2022
@arunchawla-NOAA arunchawla-NOAA changed the title Verify if CFP and grib_util are needed in (operational) forecast jobs. Check the modules loaded in ecf scripts against the job to ensure that they are used. Do this for all the jobs Jan 27, 2022
lgannoaa added a commit to lgannoaa/global-workflow that referenced this issue Feb 3, 2022
@lgannoaa
The following scripts changed to remove module load wgrib2:
be7e439 
  jenkfgdas_sfc.ecf
  jgfs_wave_prdgen_bulls.ecf
  jgdas_wave_postsbs.ecf

The following scripts changed to remove module load cfp:
  jenkfgdas_select_obs.ecf
  jenkfgdas_fcst.ecf
  jgfs_atmos_awips_master.ecf
  jgfs_atmos_wafs_grib2.ecf
  jgfs_atmos_awips_g2_master.ecf
  jgfs_atmos_fbwind.ecf
  jgfs_atmos_gempak_ncdc_upapgif.ecf
  jgfs_atmos_npoess_pgrb2_0p5deg.ecf
  jgfs_atmos_pgrb2_spec_gempak.ecf
  jgfs_wave_prdgen_bulls.ecf
  jgfs_forecast.ecf
  jgdas_forecast.ecf
  jgdas_atmos_gempak_meta_ncdc.ecf

The following scripts changed to remove module load grib_util:
  jenkfgdas_fcst.ecf
  jgfs_atmos_postsnd.ecf
  jgfs_atmos_wafs_gcip.ecf
  jgfs_atmos_gempak.ecf
  jgfs_atmos_gempak_ncdc_upapgif.ecf
  jgfs_atmos_gempak_meta.ecf
  jgfs_atmos_npoess_pgrb2_0p5deg.ecf
  jgfs_atmos_pgrb2_spec_gempak.ecf
  jgfs_wave_prep.ecf
  jgfs_wave_gempak.ecf
  jgfs_wave_prdgen_bulls.ecf
  jgfs_forecast.ecf
  jgdas_forecast.ecf
  jgdas_atmos_gempak.ecf
  jgdas_atmos_gempak_meta_ncdc.ecf
  jgdas_wave_prep.ecf

The following scripts changed to remove module load libjpeg:
  jenkfgdas_fcst.ecf
  jgfs_atmos_postsnd.ecf
  jgfs_atmos_wafs_gcip.ecf
  jgfs_atmos_gempak.ecf
  jgfs_atmos_gempak_ncdc_upapgif.ecf
  jgfs_atmos_gempak_meta.ecf
  jgfs_atmos_npoess_pgrb2_0p5deg.ecf
  jgfs_atmos_pgrb2_spec_gempak.ecf
  jgfs_wave_gempak.ecf
  jgfs_wave_prdgen_bulls.ecf
  jgfs_forecast.ecf
  jgdas_forecast.ecf
  jgdas_atmos_gempak.ecf
  jgdas_atmos_gempak_meta_ncdc.ecf

The following scripts changed to remove module load gempak
  jgfs_wave_prdgen_bulls.ecf

The following scripts changed to remove module load hdf5
  jgfs_wave_prdgen_bulls.ecf

The following scripts changed to remove module load netcdf
  jgfs_wave_prdgen_bulls.ecf

The following scripts changed to remove module load bufr
  jgfs_wave_prdgen_bulls.ecf

The following scripts changed to remove module load esmf
  jgfs_forecast.ecf
  jgdas_forecast.ecf

Merge NCO resource change:
  jgfs_atmos_analysis.ecf
  jgfs_wave_post_bndpnt.ecf
  jgfs_wave_postpnt.ecf
  jgdas_atmos_analysis.ecf
  jgdas_wave_postpnt.ecf

GitHub issue NOAA-EMC#587
@lgannoaa lgannoaa mentioned this issue Feb 3, 2022
Merged
3 tasks
lgannoaa added a commit to lgannoaa/global-workflow that referenced this issue Feb 3, 2022
@lgannoaa
1.
0e081f9 
  A check on job/ush/script from HOMEgfs, I found the following reference to USE_CFP:
  gldas_forcing.sh
  exgdas_atmos_chgres_forenkf.sh
  exgdas_atmos_gldas.sh
  exgdas_enkf_update.sh
  exglobal_atmos_analysis.sh
  exglobal_diag.sh

Therefore, remove the export USE_CFP=YES from the following ecflow scripts:
  jenkfgdas_ecen.ecf
  jenkfgdas_sfc.ecf
  jenkfgdas_select_obs.ecf
  jenkfgdas_post_master.ecf
  jenkfgdas_fcst.ecf
  jgdas_forecast.ecf
  jgdas_atmos_analysis_calc.ecf
  jgdas_atmos_emcsfc_sfc_prep.ecf
  jgdas_atmos_tropcy_qc_reloc.ecf
  jgdas_atmos_gempak_meta_ncdc.ecf
  jgdas_atmos_post_manager.ecf
  jgfs_atmos_awips_master.ecf
  jgfs_atmos_wafs_master.ecf
  jgfs_atmos_wafs_blending_0p25.ecf
  jgfs_atmos_wafs_blending.ecf
  jgfs_atmos_wafs_grib2.ecf
  jgfs_atmos_wafs_grib2_0p25.ecf
  jgfs_atmos_awips_g2_master.ecf
  jgfs_atmos_fbwind.ecf
  jgfs_atmos_analysis_calc.ecf
  jgfs_atmos_emcsfc_sfc_prep.ecf
  jgfs_atmos_tropcy_qc_reloc.ecf
  jgfs_atmos_gempak.ecf
  jgfs_atmos_gempak_ncdc_upapgif.ecf
  jgfs_atmos_npoess_pgrb2_0p5deg.ecf
  jgfs_atmos_pgrb2_spec_gempak.ecf
  jgfs_atmos_post_manager.ecf
  jgfs_forecast.ecf

2. Undo change related to resource updates
3. Remove esmf from efcs.

Reference to GitHub NOAA-EMC#587
@lgannoaa lgannoaa closed this as completed Feb 7, 2022
@aerorahul
Copy link
Contributor Author

@lgannoaa
I believe PR #629 addressing this issue is still open and unmerged.
This issue will be automatically closed/resolved when the PR #629 is merged into its destination branch.
Issues are linked to PR's and are closed with the PR, unless the issue is resolved or deemed unnecessary through other means (e.g. discussion etc).

Also, can you please provide information from NCO regarding their validation of a successful test? You can either ask NCO to comment on their approval of their test with this branch in this issue or in the PR #629. I believe they have done that in the past.

@aerorahul aerorahul reopened this Feb 8, 2022
@lgannoaa
Copy link
Contributor

lgannoaa commented Feb 8, 2022

@aerorahul you are right. Contacted Wei Wei and he requested another change to remove a library from gfs/gdas wave prep job.
I made the change and tested it.
Wei Wei confirmed it is also tested in para in an email.

@KateFriedman-NOAA
Copy link
Member

Completed via #629

kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this issue May 30, 2024
@SamuelTrahanNOAA
Fix boundary issues and numerical precision trouble in RUC LSM (NOAA-…
2458535 
…EMC#587)

* fixes and workarounds for uninitialized memory in fv_regional_bc

* initialize kmaxfire in module_bl_mynn

* smoke bug fixes for restart

* remove smoke bug fixes

* remove workarounds and fix remaining known bugs in ps_reg

* a few more surface pressure bug fixes; now the test case runs in debug mode

* ccpp/physics: module_sf_ruclsm imprecision workaround for gfortran -DDEBUG=ON

* move sanity checks to lsm_ruc and add "snow on ice" check

* use i-1 & j-1 for two-point averages, when available

* Replace many changes with atmos_cubed_sphere PR NOAA-EMC#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgannoaa lgannoaa

Labels
help wanted Extra attention is needed implementation work Work for current implementation version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aerorahul @lgannoaa @KateFriedman-NOAA