Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the eomg job #2525

Open
DavidHuber-NOAA opened this issue Apr 23, 2024 · 8 comments
Open

Remove the eomg job #2525

DavidHuber-NOAA opened this issue Apr 23, 2024 · 8 comments
Labels
feature New feature or request

Comments

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Apr 23, 2024

What new functionality do you need?

The eomg job is no longer supported for the GSI and the GDASApp has its own jobs to handle observational diagnostics (i.e. when lobsdiag=".true."): atmensanlobs and atmensanlsol. Thus, the eomg job should be removed from the global workflow without affecting the new atmensanlobs and atmensanlsol jobs.

What are the requirements for the new functionality?

All references to eomg are removed and job-specific scripts are removed from the global workflow without affecting the new GDASApp jobs. Also, eomg-specific archiving is removed and/or replaced with GDASApp-specific archiving instructions.

@DavidHuber-NOAA DavidHuber-NOAA added bug Something isn't working triage Issues that are triage labels Apr 23, 2024
@aerorahul
Copy link
Contributor

@CatherineThomas-NOAA Is the functionality of eomg.sh and its use needed to be supported?

@CatherineThomas-NOAA
Copy link
Contributor

@aerorahul I don't think so, especially given that we didn't notice the job was missing. Let me ask around a bit though.

@aerorahul
Copy link
Contributor

Thanks @CatherineThomas-NOAA. In that case we will eliminate the configurable option for lobsdiag_for_enkf and simplify the scripting.

@RussTreadon-NOAA
Copy link
Contributor

g-w issue #2415 was opened to add JEDI ATM equivalents to to eomg and eobs. These jobs perform observation quality control and h(x) for ensemble member states, eomg, and ensemble mean states, eobs. While we may not need eomg.sh for GSI ATM DA. We will likely be adding it for JEDI ATM DA.

@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Nov 19, 2024
@DavidHuber-NOAA
Copy link
Contributor Author

Adding blocked while waiting for the GDASApp-equivalent job to replace eomg.

@DavidHuber-NOAA DavidHuber-NOAA added the blocked Issue is currently being blocked by another issue label Jan 6, 2025
@RussTreadon-NOAA
Copy link
Contributor

While we do not have a separate eomg job for GDASApp, the functionality of eomg currently exists in g-w. When GDASApp is run with lobsdiag_forenkf=".false.", we run a single job, atmensanlletkf, which combines eomg and eupd into a single executation of gdas.x. The wall time and memory requirements for this combined approach make it unpractical for all but coarse resolutions with few ensemble members.

When GDASApp is run lobsdiag_forenkf=".true." we have two g-w jobs: atmensanlobs and atmensanlsol. Job atmensanlobs is the GDASApp equivalent of GSI-based eobs. The split approach is more efficient in terms of memory and wall time.

@DavidHuber-NOAA
Copy link
Contributor Author

OK, so then it sound like this issue is OBE. Agreed @aerorahul @WalterKolczynski-NOAA?

@DavidHuber-NOAA DavidHuber-NOAA changed the title Missing eomg.sh Remove the eomg job Jan 7, 2025
@DavidHuber-NOAA DavidHuber-NOAA added feature New feature or request and removed bug Something isn't working blocked Issue is currently being blocked by another issue labels Jan 7, 2025
@DavidHuber-NOAA
Copy link
Contributor Author

I updated the description of this issue to reflect that the eomg job should be removed from the global workflow without affecting the new GDASApp equivalent jobs. I am also removing the blocked label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants