Clean up orog fix directory #1206
Assignees
Labels
maintenance
Regular updates and maintenance work
Static Data Mgmt
Update of static data (fix, ICs, etc.)
Comments
|
The mosaic and grid tile filenames are built-in to the grid_spec file, so those filenames will remain unchanged for now. There is a preview available on Orion at Example listing: |
|
Per Fanglin, @GeorgeGayno-NOAA should be the contact about the top-level orog apparent source data/scripts. |
|
@WalterKolczynski-NOAA I assume you are asking about these files:
|
|
@GeorgeGayno-NOAA Not just those, but also the other files at the base of the orog fix directory that mostly look like source files for the generation process: |
Some of these files are needed. And some are not used anymore. Let me investigate a bit. |
|
UFS_UTILS uses GlobalLakeDepth.dat and GlobalLakeStatus.dat to add lakes to our model grids. So, keep those. The other "GlobalLake"files were added later and appear to be different versions of these files created from other sources. You will need to ask Shan Sun if they are needed. |
|
@GeorgeGayno-NOAA I'm not saying get rid of them entirely, but do they belong in the general fix rather than some other place if they are only needed to generate the files actually used by the models (which would go in fix)? @shansun6 can you provide more information? |
|
All files starting with GlobalLake are needed to generate fractional lake data in the orography file from different sources. The rest of the files on George's list are not from me or Ning Wang. Thanks for asking. |
|
@shansun6 but they're not used by the model directly, right? Only to generate the grid data? |
|
That is correct: all GlobalLake* files are used to generate oro_data. |
These files are used as input to create model grids. So, if you want to move then to a different location, feel free. |
|
Okay, here is my proposal of what should happen:
|
|
Walter, these are all good ideas; however, I'd recommend we still keep those source files in the same place. All the "fix" files are nevertheless saved on local platforms. They do not interfere with github. By keeping them in the top layer of model resolution specific directories we always know what source files had been used to create the files on the tiles. I understand one can move them to a different location to make this directory cleaner, but there is always a risk of losing track of these files during machine upgrades and staff changes. |
|
Raw orog files used for orography fix file generation were moved to a top-level These raw files aren't used at runtime in the GFS/global-workflow so we don't need to move to the new UFS_UTILS hash because of this cleanup. |
|
Renamed Within the |
KateFriedman-NOAA
added
the
Static Data Mgmt
4 tasks
4 tasks
|
Completed by #2181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The non-fractional grid files are no longer needed in the
fix/orogdirectory. Additionally, there is some clean-up of file names to be had (removing the resolution, using names used at runtime, etc.).Also, the top of
fix/oroghas some files that look like they are scripts or source files for generating the orog files that can be removed from fix and placed elsewhere. Will seek guidance from @yangfanglin on these.Dependencies
Depends on #863 / #1182 to update the fix version in workflow, but the new fix version can be created and staged in the interim.
The text was updated successfully, but these errors were encountered: