Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert GFS DDTs from blocked data structures to contiguous arrays (now also includes https://github.com/NOAA-EMC/fv3atm/pull/752) #798

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 11, 2024

Description

In fv3atm and submodules, convert internal GFS DDTs from blocked data structures to contiguous arrays. This excludes the (external) GFS_extdiag and GFS_restart DDTs. Also remove the GFS_Data super DDT and use the individual DDTs directly.

This PR also includes the changes from #752 (Add unit testing from @AlexanderRichert-NOAA).

Issue(s) addressed

Working towards ufs-community/ufs-weather-model#2294

Testing

See ufs-community/ufs-weather-model#2183

Dependencies

Associated PRs:

@climbfuji
Copy link
Collaborator Author

@climbfuji If it's not too much trouble, can you please merge #752 with this PR. The #752 adds few additional files that support unit testing and as far as I can see they should not have any impact on the changes introduced in this PR. If prefer not to do that, that's perfectly fine, we can merge it separately or combine it with some other PR.

I can do that, no problem - should be able to get this done this morning

@climbfuji
Copy link
Collaborator Author

Done. See note in ufs-w-m PR.

@climbfuji climbfuji changed the title Convert GFS DDTs from blocked data structures to contiguous arrays Convert GFS DDTs from blocked data structures to contiguous arrays (now also includes https://github.com/NOAA-EMC/fv3atm/pull/752) Jun 27, 2024
@climbfuji climbfuji mentioned this pull request Jun 27, 2024
@zach1221
Copy link
Collaborator

zach1221 commented Aug 6, 2024

@DusanJovic-NOAA @BrianCurtis-NOAA are you able to provide a review here?

@zach1221 zach1221 requested a review from jkbk2004 August 8, 2024 12:38
@grantfirl
Copy link
Collaborator

Apologies for merging delay. ufs-community/ccpp-physics#183 has been merged, so this is ready to update. @climbfuji @zach1221

@zach1221
Copy link
Collaborator

zach1221 commented Aug 8, 2024

@climbfuji cubed-sphere 330 is also merged.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Aug 8, 2024

@jkbk2004 Thanks for reverting .gitmodules and pushing the submodule updates. Is there anything left to do for me?

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 8, 2024

@climbfuji we will take from here. thanks a lot for all the work!

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Aug 8, 2024

@DusanJovic-NOAA can you resolve the conversation and merge?

@DusanJovic-NOAA DusanJovic-NOAA merged commit aa14843 into NOAA-EMC:develop Aug 8, 2024
6 checks passed
@climbfuji climbfuji deleted the feature/chunked_array_support_use_it branch August 9, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants