Added coupling of GOCART aerosols with radiation related to issue#899… #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in NCAR/ccpp-physics
|
looks good. Approved |
grantfirl
reviewed
May 5, 2022
|
Bc means black carbon
…On Thu, May 5, 2022 at 10:34 AM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/data/GFS_typedefs.meta
<#525 (comment)>:
> + dimensions = ()
+ type = integer
+[ntss5]
+ standard_name = index_for_seasalt_bin5
+ long_name = index for seasalt bin5
+ units = index
+ dimensions = ()
+ type = integer
+[ntsu]
+ standard_name = index_for_sulfate
+ long_name = index for sulfate
+ units = index
+ dimensions = ()
+ type = integer
+[ntbcb]
+ standard_name = index_for_bcphobic
I understand phobic and philic, but what does 'bc' stand for in these
standard names? Can it be changed to something more descriptive for
non-subject matter experts?
—
Reply to this email directly, view it on GitHub
<#525 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJWU6Z6WYYHSB5ZKJDVIPL7NANCNFSM5UL3QXLQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
On Thu, May 5, 2022 at 10:57 AM Grant Firl ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ccpp/data/GFS_typedefs.meta
<#525 (comment)>:
> + dimensions = ()
+ type = integer
+[ntss5]
+ standard_name = index_for_seasalt_bin5
+ long_name = index for seasalt bin5
+ units = index
+ dimensions = ()
+ type = integer
+[ntsu]
+ standard_name = index_for_sulfate
+ long_name = index for sulfate
+ units = index
+ dimensions = ()
+ type = integer
+[ntbcb]
+ standard_name = index_for_bcphobic
OK, thanks, @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> ,
'bc' is black carbon. I'm assuming 'oc' is organic carbon? Also, are the
philic/phobic adjectives refering to hydrophobic/hydrophilic or some other
substance? @ChunxiZhang-NOAA <https://github.com/ChunxiZhang-NOAA> Would
you mind changing associated standard names since this branch is on your
fork?
—
Reply to this email directly, view it on GitHub
<#525 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIIHD5D77BQZTGL3CFTVIPOW3ANCNFSM5UL3QXLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Yes. OC is organic Carbon. The are hydrophobic and hydrophilic too.
|
…ion in the Thompson scheme
Closed
…tputs in the Thompson microphysics scheme
DusanJovic-NOAA
approved these changes
Jul 5, 2022
junwang-noaa
approved these changes
Jul 5, 2022
|
@ChunxiZhang-NOAA can you resolve the above conversation about "bc"? |
@jkbk2004 done. |
|
@ChunxiZhang-NOAA revert gitmodule pointer and then we can merge this pr. |
|
@ChunxiZhang-NOAA update ccpp submodule pointer as well. |
|
@jkbk2004 ccpp/physics submodule pointer was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The coupling between GOCART aerosols and radiation was implemented. This is a new feature.
Issue(s) addressed
Issue is described here
Dependencies