Noah MP updates for Prototype 8 (GFSv17) #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modification to add extra land fields to the output
…urface_fields modification for addtional land outputs
correct the path for ccpp-physics
16 tasks
make those three extra land outputs as Noah MP only
grantfirl
reviewed
Nov 29, 2021
ccpp/data/GFS_typedefs.F90
Outdated
| @@ -6415,6 +6425,7 @@ subroutine diag_create (Diag, IM, Model) | |||
| allocate (Diag%snohfa (IM)) | |||
| allocate (Diag%transa (IM)) | |||
| allocate (Diag%sbsnoa (IM)) | |||
| allocate (Diag%paha (IM)) | |||
There was a problem hiding this comment.
According to NCAR/ccpp-physics#729, some of the additional variables are only used when NoahMP is active. You may want to conditionally allocate these when lsm==lsm_noahmp to save memory.
climbfuji
reviewed
Nov 29, 2021
climbfuji
approved these changes
Dec 2, 2021
DusanJovic-NOAA
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of Noah MP upgrades for P8 - adding some extra surface fields to the model output. The other parts only involves CCPP-Physics.
Add some extra surface fields required to close the offline energy/water budget computation. These fields are listed below:
LAND FRACTION
INST PREC ADVEC HEAT
WATER IN AQUIFER
ACM EIWATER(CANOPY WATER EVAPORATION)
ACM PLANTTR( PLANT TRANSPIRATION)
ACM SOILSE (BARE SOIL EVAPORATION)
AVE PREC ADVEC HEAT
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs