Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model sends wrong tile_num to CCPP for nests #797

Closed
SamuelTrahanNOAA opened this issue Mar 11, 2024 · 0 comments · Fixed by #806
Closed

Model sends wrong tile_num to CCPP for nests #797

SamuelTrahanNOAA opened this issue Mar 11, 2024 · 0 comments · Fixed by #806
Labels
bug Something isn't working

Comments

@SamuelTrahanNOAA
Copy link
Contributor

SamuelTrahanNOAA commented Mar 11, 2024

Description

In a global simulation with a static nest, the nest thinks it is on tile 1. Some suites read per-tile static data. The nest data must come from tile 7, but the nest tries to read tile 1 instead. It happens because CCPP receives tile_in_mosaic instead of global_tile from the atmos_cubed_sphere.

To fix this, we'll need to get the global_tile from the dynamical core. This issue documents that:

To Reproduce:

What compilers/machines are you seeing this with?
N/A. Machine and compiler don't affect it.

Give explicit steps to reproduce the behavior.

  1. Run a global simulation with a static nest.
  2. Print the tile_num, or use a suite that reads in per-tile static data
  3. Tile_num is wrong (or model crashes due to reading the wrong tile).

Additional context

I have a fix for this already, which I'll PR soon. It includes a fix for another bug (or two) which I must fix to run the test case.

Testing:

Have you tested the code changes?

Yes. I have a test case of the GFS with a static nest using current GFS physics. It has per-tile static data for all seven tiles.

On what platforms?

Hera Intel Centos.

Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?

Not yet.

Will the baseline results change?

Will know that after I run the regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant