Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CCPP_interstitial_type and CCPP_interstitial (variable) #507

Closed
climbfuji opened this issue Mar 20, 2022 · 0 comments · Fixed by #508 or ufs-community/ufs-weather-model#1130
Closed

Rename CCPP_interstitial_type and CCPP_interstitial (variable) #507

climbfuji opened this issue Mar 20, 2022 · 0 comments · Fixed by #508 or ufs-community/ufs-weather-model#1130
Labels
enhancement New feature or request

Comments

@climbfuji
Copy link
Collaborator

Description

In #506, it is proposed to move GFS_interstitial_type from GFS_typedefs.F90 to CCPP_typedefs.F90. This file already has an interstitial DDT CCPP_interstitial_type that is used for the FV3 dycore. The latter name CCPP_interstitial_type is confusing, because GFS_interstitial_type is also an interstitial type used by CCPP.

Solution

A PR to the FV3 dycore was made (NOAA-GFDL/GFDL_atmos_cubed_sphere#181), in which a new name is proposed. Once agreed upon, the definition in fv3atm must be changed accordingly.

Alternatives

Keep as is.
@climbfuji climbfuji added the enhancement New feature or request label Mar 20, 2022
This was referenced Mar 20, 2022
Merged
Merged
Merged
SamuelTrahanNOAA pushed a commit to SamuelTrahanNOAA/fv3atm that referenced this issue Jun 13, 2022
@climbfuji
Wrapper PR for NOAA-EMC#479, NOAA-EMC#508, NOAA-EMC#507: zorl interst…
65f5341 
…itial, ocn -> wat, merra2 threading (NOAA-EMC#520)

* changed .gitmodules to point to merra2  fv3atm
* Update .gitmodules and submodule pointer for fv3atm for code review and testing
* update submodule pointer for fv3atm
* Update regression test baseline date in tests/rt.sh; run-ci
* RT JOBS PASSED: hera.gnu. Log file uploaded.
* RT JOBS PASSED: gaea.intel. Log file uploaded.
* RT JOBS PASSED: hera.intel. Log file uploaded.
* RT JOBS PASSED: orion.intel. Log file uploaded.
* Regression test logs for wcoss_dell_p3 and wcoss_cray
* Regression test logs for cheyenne.gnu
* Regression test logs for cheyenne.intel
* Regression test log for jet.intel
* Revert change to .gitmodules and update submodule pointer for fv3atm
Co-authored-by: anning.cheng <anning.cheng@noaa.gov>
Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@climbfuji