CALSLR_ROEBBER: Instead of calling BOUND incorrectly, use min and max
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2023
SamuelTrahanNOAA
changed the title
CALSLR_ROEBBER: Instead of calling BOUND incorrectly, don't call it at allCALSLR_ROEBBER: Instead of calling BOUND incorrectly, use min and max
WenMeng-NOAA
added
bug
|
I just noticed I added a blank line by accident. The ufs-weather-model regression tests are already running, so I'd rather not remove the accidental blank line. It can't affect anything since the Fortran parser eliminates blank lines before the compiler sees them. |
|
Apparently the author year is wrong too. That seems somewhat more important than a blank line. |
|
@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop? |
WenMeng-NOAA
approved these changes
Mar 22, 2023
|
The UPP RT tests were completed on WCOSS2, Hera and Orion without changed results. This PR is ready for merging. |
WenMeng-NOAA
added
the
No Baseline Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #672 by calling min and max in CALSLR_ROEBBER instead of calling BOUND incorrectly.
Fixes #674 the same way.