add ctest and nemsio utilities. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibb9ae9d92106bd9389d4fe2a61c3e5cde3f30805
Change-Id: I76efdda7a3e38775dbd05229008219850c54e928
Change-Id: I3e99e64a7ad09359722edef6d42ab564a65b4828
Closed
GeorgeGayno-NOAA
approved these changes
May 18, 2020
There was a problem hiding this comment.
I ran mkgfsnemsioctl, nemsio_chgdate, nemsio_get and nemsio_read using a canned dataset. I then reran using the UFS_UTILS versions of these utilities. The output matched. So, these utilities were correctly incorporated into the nemsio library. I can't speak to the other changes made under this pull request.
|
Thanks, All,
It is very good.
Hang
…On Mon, May 18, 2020 at 11:53 AM Kyle Gerheiser ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKWSMFG5K6APWIBX5BJYR63RSFKVXANCNFSM4NCP6GPA>
.
|
|
Please let me know when this gets installed on WCOSS and our RDHPCS machines. Then, I will remove them from UFS_UTILS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
nemsio_get,nemsio_read,nemsio_chgdate,mkgfsnemsioctlfrom UFS_UTILS here. These are the current versions fromfeature/cmakebranch from the fork of @GeorgeGayno-NOAA