Update global_4denvar and global_enkf ctests to reflect GFS v17

[RussTreadon-NOAA]

Description
Update global_4denvar and global_enkf ctest configurations to better align with GFS v17 configuration.

Resolves #759

Type of change

• Maintenance - update global ctest configuration

How Has This Been Tested?

1. install RussTreadon-NOAA/GSI:feature/global_ctests on Hera
2. run global_4envar and global_enkf ctests

Both tests pass

Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/global_ctests/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  1926.51 sec
    Start 6: global_enkf
2/2 Test #6: global_enkf ......................   Passed  755.75 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 2682.29 sec

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing tests pass with my changes

[RussTreadon-NOAA]

WCOSS2 (Cactus) test
Install RussTreadon-NOAA:feature/global_ctests on Cactus. Run global ctests with following results

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/pr774/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  1684.42 sec
    Start 6: global_enkf
2/2 Test #6: global_enkf ......................   Passed  852.93 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 2537.53 sec

[RussTreadon-NOAA]

Hercules test
Install RussTreadon-NOAA:feature/global_ctests on Hercules. Run global ctests with following results

Test project /work/noaa/da/rtreadon/git/gsi/pr774/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  2222.24 sec
    Start 6: global_enkf
2/2 Test #6: global_enkf ......................   Passed  1206.22 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 3428.47 sec

[azadeh-gh]

looks good.

[CatherineThomas-NOAA]

@RussTreadon-NOAA: Should the debug test also be updated? I see you added the imp_physics change, but it looks like that test is quite out of sync with regression_namelist.sh. I have the script comparison on Hera here:
/scratch1/NCEPDEV/da/Catherine.Thomas/gsi/russ_pr/regression/diff

Different parameters between scripts:

• iterations
• RO parameters: nsig_ext, gpstop, commgps*
• incvars*
• obslist

Missing parameters in regression_namelist_db.sh:

• optconv=0.05,cao_check=.true.,ta2tb=.true.,
• tcp*, *cads
• dmesh(4)
• hub_norm

[RussTreadon-NOAA]

@CatherineThomas-NOAA , thank you for noting differences between the namelists in regression_namelists.sh and regression_namelists_db.sh.

The debug option traces back to svn. I am not aware of anyone who uses the debug ctests. I don't. When I want to test changes in debug mode, I build with BUILD_TYPE=Debug and run the standard suite of ctests. The wall times need to be increased when doing this. I'd be fine with removing the debug flag and associated scripting (namelists) from regression/.

The GSI Review team has talked about an overhaul of the GSI ctest suite. The checks performed by the test scripts need to be refactored. The current checks generate too many false positives. Run scripts should be cleaned up and standardized. Thus far, no one has found time to go through this cleanup, enhancing, and refactoring task.

[RussTreadon-NOAA]

Build RussTreadon-NOAA:feature/global_ctests at 11a80d6 on Cactus. Run global_ ctests with the folowing results

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/global_ctests/build
    Start 1: global_4denvar
1/2 Test #1: global_4denvar ...................   Passed  1683.88 sec
    Start 6: global_enkf
2/2 Test #6: global_enkf ......................   Passed  853.32 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) = 2537.24 sec

[CatherineThomas-NOAA]

Thanks for your comments @RussTreadon-NOAA. Being able to run in debug mode using the standard ctests makes much more sense than using a separate debug script where we have to make changes in multiple places. Looks good to me. Approve.