A quick fix for incorrect usage of real(i_kind) in mg_input.f90 #760
Conversation
…ich was identified by D. Kokron. NOAA-EMC#757 . Co-author : D. Kokron
|
@TingLei-NOAA, @hu5970 , and @ShunLiu-NOAA: I did not realize that we do not exercise mgbf in any of the regional ctests. This is not good. We intend to use mgbf in an operational realizations of the GSI, right? If true, we should exercise mgbf code as part of our standard GSI regression (ctest) suite. What is the impact of correctly defining the variables in question as |
|
@RussTreadon-NOAA, we have no plan to use MGBF in RRFSv1. We expect to use it in RRFSv2 with JEDI. |
|
Thank you @ShunLiu-NOAA for this very surprising news. If we do not intend to use mbgf in an operational realization of GSI why did we add it to the GSI repository? |
|
I am not sure if 3DRTMA will implement this. Also, for JEDI-MGBF development, it is necessary to test MGBF with GSI first. This is what Ting and other developers are working on. |
|
Thanks, @ShunLiu-NOAA. Given your reply we need a mgbf ctest in GSI. This PR can use this new ctest. Who will create the mgbf ctest? Adding @ManuelPondeca-NOAA for awareness. |
|
@RussTreadon-NOAA Thank you. We will work with Ting to provide a regional DA test case. |
|
Great! Thank you @ShunLiu-NOAA and @TingLei-NOAA . |
|
@TingLei-daprediction , what is the status of this PR? |
|
@russ Treadon - NOAA Federal ***@***.***> When we began
preparing a ctest for mgbf with GSI, I learned that the current
implementation of mgbf won't guarantee the reproducibility using different
mpi process numbers.
As far as I know, there is no specific timelines, yet, for when that
capability would be available with an upgraded MGBF package. I will come
back with more updates when any specific plan is made.
…______________________________
Ting Lei
Physical Scientist, Contractor with Lynker in support of
EMC/NCEP/NWS/NOAA
5830 University Research Ct., Cubicle 2765
College Park, MD 20740
***@***.***
301-683-3624
On Mon, Aug 5, 2024 at 5:56 AM RussTreadon-NOAA ***@***.***> wrote:
@TingLei-daprediction <https://github.com/TingLei-daprediction> , what is
the status of this PR?
—
Reply to this email directly, view it on GitHub
<#760 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEFS7CG26KXY7A26NXHZY3ZP5D5RAVCNFSM6AAAAABJYP2AF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRYGY3TGOJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@TingLei-NOAA , if there is no timeline for actively working on this PR, I suggest that it be closed and reopened later when a path forward is worked out. Attention @ShunLiu-NOAA |
|
As discussed in the above, this PR would be closed for being now and be re-opened when the mgbf ctest is ready |
|
Since this is an obvious error which is trivial to fix, let's get this fix into @TingLei-NOAA, if you agree that the change is correct, would you please approve this PR. @TingLei-NOAA , who else can peer review this PR? |
|
@MiodragRancic-NOAA , @dkokron found a bug in Do you have time to review this PR? We need one more peer review to merge it into |
|
@TingLei-NOAA , who do you recommend as the second per reviewer for this PR? |
|
@RussTreadon-NOAA I think @GangZhao-NOAA will be a good reviewer for this PR. Thanks |
|
Thank you @TingLei-NOAA . @GangZhao-NOAA added as a peer reviewer. |
* origin/develop: Move to contrib spack-stack on Jet (NOAA-EMC#787) a quick workaround for increasing the mpi task numbers on orion for ctest :: rrfs_3denvar_rdasens (NOAA-EMC#788) Recover the capability of handling model fields from operation gfs.v16.3 (NOAA-EMC#785) fix a bug in deter_sfc_gmi (NOAA-EMC#781) add safeguard to thompson_reff (NOAA-EMC#779) Fix incorrect usage of real(i_kind) in mg_input.f90 (NOAA-EMC#760) Transition to Thompson Microphysics for Microwave All-sky Assimilation (NOAA-EMC#743) Format changes for EUMETSAT metop-sg and CADS debug fix (NOAA-EMC#773) Update global_4denvar and global_enkf ctests to reflect GFS v17 (NOAA-EMC#774) fix for cris-fsr memory corruption (NOAA-EMC#767) Gnssrwnd1.0 (NOAA-EMC#747)
Description
A quick fix for incorrect usage of real(i_kind) in mg_input.f90 , which was identified by D. Kokron.
Fixes #757
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
The building succeeded. And the changed code mg_input.f90 is not used by other codes in the current GSI and hence the change hadn't and would not affect any GSI runs.
Coauthor : D. Kokron